Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

'Starter Project': port planet fragment shader to impeller tests #53362

Merged
merged 3 commits into from
Jun 13, 2024
Merged

'Starter Project': port planet fragment shader to impeller tests #53362

merged 3 commits into from
Jun 13, 2024

Conversation

jtmcdole
Copy link
Member

This is a modified planet shader from the SimonDev's "GLSL Shaders from Scratch" course on teachables. With permission from Simon:

100% use however you want, with or without credit

I choose "with credit".

Screen.Recording.2024-06-12.at.3.03.13.PM.mov

@jtmcdole
'Starter Project': port planet fragment shader to imepller tests
9614b79 
This is a modified planet shader from the SimonDev's
"GLSL Shaders from Scratch" course on teachables. With permission
from Simon:

> 100% use however you want, with or without credit
@jtmcdole jtmcdole requested a review from bdero June 12, 2024 22:05
jonahwilliams
jonahwilliams reviewed Jun 12, 2024
View reviewed changes
bdero
bdero approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, LGTM!

@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 12, 2024
@jonahwilliams jonahwilliams changed the title 'Starter Project': port planet fragment shader to imepller tests 'Starter Project': port planet fragment shader to impeller tests Jun 13, 2024
@auto-submit auto-submit bot merged commit cbf4ff6 into flutter:main Jun 13, 2024
27 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
cbf4ff61b 'Starter Project': port planet fragment shader to impeller …
d106ba1 
…tests (flutter/engine#53362)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
cbf4ff61b 'Starter Project': port planet fragment shader to impeller …
8aa8889 
…tests (flutter/engine#53362)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
cbf4ff61b 'Starter Project': port planet fragment shader to impeller …
0b3b2a9 
…tests (flutter/engine#53362)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
cbf4ff61b 'Starter Project': port planet fragment shader to impeller …
56be826 
…tests (flutter/engine#53362)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
cbf4ff61b 'Starter Project': port planet fragment shader to impeller …
8428009 
…tests (flutter/engine#53362)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
cbf4ff61b 'Starter Project': port planet fragment shader to impeller …
17073ac 
…tests (flutter/engine#53362)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
cbf4ff61b 'Starter Project': port planet fragment shader to impeller …
ed801a0 
…tests (flutter/engine#53362)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
cbf4ff61b 'Starter Project': port planet fragment shader to impeller …
736f381 
…tests (flutter/engine#53362)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
cbf4ff61b 'Starter Project': port planet fragment shader to impeller …
00f381e 
…tests (flutter/engine#53362)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
cbf4ff61b 'Starter Project': port planet fragment shader to impeller …
5f3d51b 
…tests (flutter/engine#53362)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
cbf4ff61b 'Starter Project': port planet fragment shader to impeller …
73931c7 
…tests (flutter/engine#53362)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
cbf4ff61b 'Starter Project': port planet fragment shader to impeller …
c3c1cbb 
…tests (flutter/engine#53362)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
Roll Flutter Engine from c7fcbfce608f to 4cb3025d3abf (28 revisions) (#…
01db23b 
…150199)

flutter/engine@c7fcbfc...4cb3025

2024-06-13 [email protected] Roll Skia from 0fe7f7ac43c5 to ecc64fb82374 (1 revision) (flutter/engine#53374)
2024-06-13 [email protected] Roll Skia from 9ea9f37e8e1d to 0fe7f7ac43c5 (1 revision) (flutter/engine#53373)
2024-06-13 [email protected] Roll Skia from b12af56eb100 to 9ea9f37e8e1d (1 revision) (flutter/engine#53372)
2024-06-13 [email protected] Roll Skia from 704f70b7d756 to b12af56eb100 (1 revision) (flutter/engine#53371)
2024-06-13 [email protected] Roll Skia from 69a53db434a6 to 704f70b7d756 (2 revisions) (flutter/engine#53370)
2024-06-13 [email protected] Roll Skia from b2f163ae11bf to 69a53db434a6 (8 revisions) (flutter/engine#53365)
2024-06-13 [email protected] [Impeller] Move Gradient tests to display list. (flutter/engine#53345)
2024-06-13 [email protected] Roll Fuchsia Linux SDK from 5VG7IYkpANkfxMKYx... to pGxbL7JoNb3yAYFw4... (flutter/engine#53363)
2024-06-13 [email protected] Roll Skia from be6a57569a92 to b2f163ae11bf (5 revisions) (flutter/engine#53357)
2024-06-13 [email protected] Give mac_host_engine tests a longer timeout and allow to run on Mac-14 (flutter/engine#53355)
2024-06-13 [email protected] 'Starter Project': port planet fragment shader to impeller tests (flutter/engine#53362)
2024-06-12 [email protected] Roll Skia from 1ba0c3ebc7a5 to be6a57569a92 (1 revision) (flutter/engine#53353)
2024-06-12 [email protected] Roll Dart SDK from 24fbead7105d to aa2265e5a192 (1 revision) (flutter/engine#53352)
2024-06-12 [email protected] Roll Skia from 52d829ac6a0b to 1ba0c3ebc7a5 (1 revision) (flutter/engine#53351)
2024-06-12 [email protected] Roll Skia from 5bfbacc89543 to 52d829ac6a0b (1 revision) (flutter/engine#53350)
2024-06-12 [email protected] Roll Skia from 51eabd0d1e44 to 5bfbacc89543 (1 revision) (flutter/engine#53349)
2024-06-12 [email protected] Roll Dart SDK from b61536f05f99 to 24fbead7105d (1 revision) (flutter/engine#53348)
2024-06-12 [email protected] Roll Dart SDK from 269125c33a35 to b61536f05f99 (1 revision) (flutter/engine#53347)
2024-06-12 [email protected] [Impeller] disabling the color write mask seems to improve performance on iOS compared to just the blend options. (flutter/engine#53322)
2024-06-11 [email protected] Roll Fuchsia Linux SDK from LS0Ff8PwQEGXzO0iA... to 5VG7IYkpANkfxMKYx... (flutter/engine#53346)
2024-06-11 [email protected] Roll Dart SDK from ab4d5a0b789d to 269125c33a35 (1 revision) (flutter/engine#53344)
2024-06-11 [email protected] [Impeller] makes bgra10xr test more comprehensive (flutter/engine#53320)
2024-06-11 [email protected] Roll Skia from af907b24d873 to 51eabd0d1e44 (1 revision) (flutter/engine#53343)
2024-06-11 [email protected] [Impeller] add missing position to exp canvas text. (flutter/engine#53339)
2024-06-11 [email protected] Roll Skia from 4cbc1129e587 to af907b24d873 (1 revision) (flutter/engine#53341)
2024-06-11 [email protected] Revert "[web] switch from .didGain/LoseAccessibilityFocus to .focus (â�¦ (flutter/engine#53342)
2024-06-11 [email protected] [Impeller] move some tests from aiks to display list. (flutter/engine#53336)
2024-06-11 [email protected] Roll Skia from b5f974ec2dcd to 4cbc1129e587 (1 revision) (flutter/engine#53340)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from LS0Ff8PwQEGX to pGxbL7JoNb3y

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @victorsanni
Roll Flutter Engine from c7fcbfce608f to 4cb3025d3abf (28 revisions) (f…
bd6de6d 
…lutter#150199)

flutter/engine@c7fcbfc...4cb3025

2024-06-13 [email protected] Roll Skia from 0fe7f7ac43c5 to ecc64fb82374 (1 revision) (flutter/engine#53374)
2024-06-13 [email protected] Roll Skia from 9ea9f37e8e1d to 0fe7f7ac43c5 (1 revision) (flutter/engine#53373)
2024-06-13 [email protected] Roll Skia from b12af56eb100 to 9ea9f37e8e1d (1 revision) (flutter/engine#53372)
2024-06-13 [email protected] Roll Skia from 704f70b7d756 to b12af56eb100 (1 revision) (flutter/engine#53371)
2024-06-13 [email protected] Roll Skia from 69a53db434a6 to 704f70b7d756 (2 revisions) (flutter/engine#53370)
2024-06-13 [email protected] Roll Skia from b2f163ae11bf to 69a53db434a6 (8 revisions) (flutter/engine#53365)
2024-06-13 [email protected] [Impeller] Move Gradient tests to display list. (flutter/engine#53345)
2024-06-13 [email protected] Roll Fuchsia Linux SDK from 5VG7IYkpANkfxMKYx... to pGxbL7JoNb3yAYFw4... (flutter/engine#53363)
2024-06-13 [email protected] Roll Skia from be6a57569a92 to b2f163ae11bf (5 revisions) (flutter/engine#53357)
2024-06-13 [email protected] Give mac_host_engine tests a longer timeout and allow to run on Mac-14 (flutter/engine#53355)
2024-06-13 [email protected] 'Starter Project': port planet fragment shader to impeller tests (flutter/engine#53362)
2024-06-12 [email protected] Roll Skia from 1ba0c3ebc7a5 to be6a57569a92 (1 revision) (flutter/engine#53353)
2024-06-12 [email protected] Roll Dart SDK from 24fbead7105d to aa2265e5a192 (1 revision) (flutter/engine#53352)
2024-06-12 [email protected] Roll Skia from 52d829ac6a0b to 1ba0c3ebc7a5 (1 revision) (flutter/engine#53351)
2024-06-12 [email protected] Roll Skia from 5bfbacc89543 to 52d829ac6a0b (1 revision) (flutter/engine#53350)
2024-06-12 [email protected] Roll Skia from 51eabd0d1e44 to 5bfbacc89543 (1 revision) (flutter/engine#53349)
2024-06-12 [email protected] Roll Dart SDK from b61536f05f99 to 24fbead7105d (1 revision) (flutter/engine#53348)
2024-06-12 [email protected] Roll Dart SDK from 269125c33a35 to b61536f05f99 (1 revision) (flutter/engine#53347)
2024-06-12 [email protected] [Impeller] disabling the color write mask seems to improve performance on iOS compared to just the blend options. (flutter/engine#53322)
2024-06-11 [email protected] Roll Fuchsia Linux SDK from LS0Ff8PwQEGXzO0iA... to 5VG7IYkpANkfxMKYx... (flutter/engine#53346)
2024-06-11 [email protected] Roll Dart SDK from ab4d5a0b789d to 269125c33a35 (1 revision) (flutter/engine#53344)
2024-06-11 [email protected] [Impeller] makes bgra10xr test more comprehensive (flutter/engine#53320)
2024-06-11 [email protected] Roll Skia from af907b24d873 to 51eabd0d1e44 (1 revision) (flutter/engine#53343)
2024-06-11 [email protected] [Impeller] add missing position to exp canvas text. (flutter/engine#53339)
2024-06-11 [email protected] Roll Skia from 4cbc1129e587 to af907b24d873 (1 revision) (flutter/engine#53341)
2024-06-11 [email protected] Revert "[web] switch from .didGain/LoseAccessibilityFocus to .focus (â�¦ (flutter/engine#53342)
2024-06-11 [email protected] [Impeller] move some tests from aiks to display list. (flutter/engine#53336)
2024-06-11 [email protected] Roll Skia from b5f974ec2dcd to 4cbc1129e587 (1 revision) (flutter/engine#53340)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from LS0Ff8PwQEGX to pGxbL7JoNb3y

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @victorsanni
Roll Flutter Engine from c7fcbfce608f to 4cb3025d3abf (28 revisions) (f…
cd3166a 
…lutter#150199)

flutter/engine@c7fcbfc...4cb3025

2024-06-13 [email protected] Roll Skia from 0fe7f7ac43c5 to ecc64fb82374 (1 revision) (flutter/engine#53374)
2024-06-13 [email protected] Roll Skia from 9ea9f37e8e1d to 0fe7f7ac43c5 (1 revision) (flutter/engine#53373)
2024-06-13 [email protected] Roll Skia from b12af56eb100 to 9ea9f37e8e1d (1 revision) (flutter/engine#53372)
2024-06-13 [email protected] Roll Skia from 704f70b7d756 to b12af56eb100 (1 revision) (flutter/engine#53371)
2024-06-13 [email protected] Roll Skia from 69a53db434a6 to 704f70b7d756 (2 revisions) (flutter/engine#53370)
2024-06-13 [email protected] Roll Skia from b2f163ae11bf to 69a53db434a6 (8 revisions) (flutter/engine#53365)
2024-06-13 [email protected] [Impeller] Move Gradient tests to display list. (flutter/engine#53345)
2024-06-13 [email protected] Roll Fuchsia Linux SDK from 5VG7IYkpANkfxMKYx... to pGxbL7JoNb3yAYFw4... (flutter/engine#53363)
2024-06-13 [email protected] Roll Skia from be6a57569a92 to b2f163ae11bf (5 revisions) (flutter/engine#53357)
2024-06-13 [email protected] Give mac_host_engine tests a longer timeout and allow to run on Mac-14 (flutter/engine#53355)
2024-06-13 [email protected] 'Starter Project': port planet fragment shader to impeller tests (flutter/engine#53362)
2024-06-12 [email protected] Roll Skia from 1ba0c3ebc7a5 to be6a57569a92 (1 revision) (flutter/engine#53353)
2024-06-12 [email protected] Roll Dart SDK from 24fbead7105d to aa2265e5a192 (1 revision) (flutter/engine#53352)
2024-06-12 [email protected] Roll Skia from 52d829ac6a0b to 1ba0c3ebc7a5 (1 revision) (flutter/engine#53351)
2024-06-12 [email protected] Roll Skia from 5bfbacc89543 to 52d829ac6a0b (1 revision) (flutter/engine#53350)
2024-06-12 [email protected] Roll Skia from 51eabd0d1e44 to 5bfbacc89543 (1 revision) (flutter/engine#53349)
2024-06-12 [email protected] Roll Dart SDK from b61536f05f99 to 24fbead7105d (1 revision) (flutter/engine#53348)
2024-06-12 [email protected] Roll Dart SDK from 269125c33a35 to b61536f05f99 (1 revision) (flutter/engine#53347)
2024-06-12 [email protected] [Impeller] disabling the color write mask seems to improve performance on iOS compared to just the blend options. (flutter/engine#53322)
2024-06-11 [email protected] Roll Fuchsia Linux SDK from LS0Ff8PwQEGXzO0iA... to 5VG7IYkpANkfxMKYx... (flutter/engine#53346)
2024-06-11 [email protected] Roll Dart SDK from ab4d5a0b789d to 269125c33a35 (1 revision) (flutter/engine#53344)
2024-06-11 [email protected] [Impeller] makes bgra10xr test more comprehensive (flutter/engine#53320)
2024-06-11 [email protected] Roll Skia from af907b24d873 to 51eabd0d1e44 (1 revision) (flutter/engine#53343)
2024-06-11 [email protected] [Impeller] add missing position to exp canvas text. (flutter/engine#53339)
2024-06-11 [email protected] Roll Skia from 4cbc1129e587 to af907b24d873 (1 revision) (flutter/engine#53341)
2024-06-11 [email protected] Revert "[web] switch from .didGain/LoseAccessibilityFocus to .focus (â�¦ (flutter/engine#53342)
2024-06-11 [email protected] [Impeller] move some tests from aiks to display list. (flutter/engine#53336)
2024-06-11 [email protected] Roll Skia from b5f974ec2dcd to 4cbc1129e587 (1 revision) (flutter/engine#53340)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from LS0Ff8PwQEGX to pGxbL7JoNb3y

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdero bdero bdero approved these changes

@jonahwilliams jonahwilliams jonahwilliams left review comments

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtmcdole @bdero @jonahwilliams