[docs] Add missing steps to Testing Presubmit Engine PRs #54593

cbracken · 2024-08-16T22:16:50Z

Most framework tests perform a flutter precache or rely on the web SDK in some form. The Web SDK is not build in presubmit by default. As such, developers will need to manually comment out the runIf conditional block that prevents the web SDK from being built during presubmit, then later hope they uncomment it before landing their patch.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

cbracken · 2024-08-16T22:21:07Z

docs/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md

-3. Create and upload a flutter/flutter PR, (OR run tests locally).
-4. Wait for flutter/flutter presubmits/tests to run ☕.
-
-Step (1) is the usual flutter/engine workflow.


Deleted the implication that there's anything usual about this workflow, but also there's a new (1) in town.

Most framework tests perform a `flutter precache` or rely on the web SDK in some form. The Web SDK is not build in presubmit by default. As such, developers will need to manually comment out the `runIf` conditional block that prevents the web SDK from being built during presubmit, then later hope they uncomment it before landing their patch.

jmagman · 2024-08-16T22:31:15Z

docs/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md

+
+## 2. Wait
+
+Contemplate the nature of the universe or why it is that this workflow was necessary for your situation. Could tests have been added to the engine? If not, get youself some coffee and a cookie. You'll need them.


Perhaps a jar to keep the tears you will shed during this 3h process. 😂

zanderso · 2024-08-16T23:00:31Z

docs/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md

-2. Determine the commit hash for your flutter/engine PR.
-3. Create and upload a flutter/flutter PR, (OR run tests locally).
-4. Wait for flutter/flutter presubmits/tests to run ☕.
+1. Enable the web SDK presubmits.


Does test: all work in the engine repo?

What is test: all?

…lutter/engine#54593)

…153618) flutter/engine@c94651c...c9fb479 2024-08-17 [email protected] Roll Fuchsia Linux SDK from Z5hq3ZkPNCpZWRQnl... to a3zdjZKduabZSBN0B... (flutter/engine#54596) 2024-08-17 [email protected] Roll Skia from 219bd1032761 to 570b18e1afda (1 revision) (flutter/engine#54595) 2024-08-17 [email protected] macOS: Extract framework creation to sky_utils (flutter/engine#54586) 2024-08-16 [email protected] Roll Skia from fc8769175d35 to 219bd1032761 (4 revisions) (flutter/engine#54592) 2024-08-16 [email protected] [docs] Add missing steps to Testing Presubmit Engine PRs (flutter/engine#54593) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Z5hq3ZkPNCpZ to a3zdjZKduabZ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…isions) (#153618)" (#153627) Reverts: #153618 Initiated by: zanderso Reason for reverting: The tree is red. Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@c94651c...c9fb479 2024-08-17 [email protected] Roll Fuchsia Linux SDK from Z5hq3ZkPNCpZWRQnl... to a3zdjZKduabZSBN0B... (flutter/engine#54596) 2024-08-17 [email protected] Roll Skia from 219bd1032761 to 570b18e1afda (1 revision) (flutter/engine#54595) 2024-08-17 [email protected] macOS: Extract framework creation to sky_utils (flutter/engine#54586) 2024-08-16 [email protected] Roll Skia from fc8769175d35 to 219bd1032761 (4 revisions) (flutter/engine#54592) 2024-08-16 [email protected] [docs] Add missing steps to Testing Presubmit Engine PRs (flutter/engine#54593) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Z5hq3ZkPNCpZ to a3zdjZKduabZ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter/engine#54593)

…ions) (#153659) Manual roll requested by [email protected] flutter/engine@c94651c...d0d7de5 2024-08-18 [email protected] Roll Skia from ac7149e315ec to 7025ec4bff25 (1 revision) (flutter/engine#54605) 2024-08-18 [email protected] Roll Fuchsia Linux SDK from a3zdjZKduabZSBN0B... to yKkNB9F8Hwnjq2AMW... (flutter/engine#54602) 2024-08-17 [email protected] Roll Skia from 570b18e1afda to ac7149e315ec (1 revision) (flutter/engine#54600) 2024-08-17 [email protected] Shift linux_fuchsia_tests from staging to prod (flutter/engine#54597) 2024-08-17 [email protected] Roll Fuchsia Linux SDK from Z5hq3ZkPNCpZWRQnl... to a3zdjZKduabZSBN0B... (flutter/engine#54596) 2024-08-17 [email protected] Roll Skia from 219bd1032761 to 570b18e1afda (1 revision) (flutter/engine#54595) 2024-08-17 [email protected] macOS: Extract framework creation to sky_utils (flutter/engine#54586) 2024-08-16 [email protected] Roll Skia from fc8769175d35 to 219bd1032761 (4 revisions) (flutter/engine#54592) 2024-08-16 [email protected] [docs] Add missing steps to Testing Presubmit Engine PRs (flutter/engine#54593) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Z5hq3ZkPNCpZ to yKkNB9F8Hwnj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#153618) flutter/engine@c94651c...c9fb479 2024-08-17 [email protected] Roll Fuchsia Linux SDK from Z5hq3ZkPNCpZWRQnl... to a3zdjZKduabZSBN0B... (flutter/engine#54596) 2024-08-17 [email protected] Roll Skia from 219bd1032761 to 570b18e1afda (1 revision) (flutter/engine#54595) 2024-08-17 [email protected] macOS: Extract framework creation to sky_utils (flutter/engine#54586) 2024-08-16 [email protected] Roll Skia from fc8769175d35 to 219bd1032761 (4 revisions) (flutter/engine#54592) 2024-08-16 [email protected] [docs] Add missing steps to Testing Presubmit Engine PRs (flutter/engine#54593) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Z5hq3ZkPNCpZ to a3zdjZKduabZ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…isions) (flutter#153618)" (flutter#153627) Reverts: flutter#153618 Initiated by: zanderso Reason for reverting: The tree is red. Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@c94651c...c9fb479 2024-08-17 [email protected] Roll Fuchsia Linux SDK from Z5hq3ZkPNCpZWRQnl... to a3zdjZKduabZSBN0B... (flutter/engine#54596) 2024-08-17 [email protected] Roll Skia from 219bd1032761 to 570b18e1afda (1 revision) (flutter/engine#54595) 2024-08-17 [email protected] macOS: Extract framework creation to sky_utils (flutter/engine#54586) 2024-08-16 [email protected] Roll Skia from fc8769175d35 to 219bd1032761 (4 revisions) (flutter/engine#54592) 2024-08-16 [email protected] [docs] Add missing steps to Testing Presubmit Engine PRs (flutter/engine#54593) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Z5hq3ZkPNCpZ to a3zdjZKduabZ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ions) (flutter#153659) Manual roll requested by [email protected] flutter/engine@c94651c...d0d7de5 2024-08-18 [email protected] Roll Skia from ac7149e315ec to 7025ec4bff25 (1 revision) (flutter/engine#54605) 2024-08-18 [email protected] Roll Fuchsia Linux SDK from a3zdjZKduabZSBN0B... to yKkNB9F8Hwnjq2AMW... (flutter/engine#54602) 2024-08-17 [email protected] Roll Skia from 570b18e1afda to ac7149e315ec (1 revision) (flutter/engine#54600) 2024-08-17 [email protected] Shift linux_fuchsia_tests from staging to prod (flutter/engine#54597) 2024-08-17 [email protected] Roll Fuchsia Linux SDK from Z5hq3ZkPNCpZWRQnl... to a3zdjZKduabZSBN0B... (flutter/engine#54596) 2024-08-17 [email protected] Roll Skia from 219bd1032761 to 570b18e1afda (1 revision) (flutter/engine#54595) 2024-08-17 [email protected] macOS: Extract framework creation to sky_utils (flutter/engine#54586) 2024-08-16 [email protected] Roll Skia from fc8769175d35 to 219bd1032761 (4 revisions) (flutter/engine#54592) 2024-08-16 [email protected] [docs] Add missing steps to Testing Presubmit Engine PRs (flutter/engine#54593) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Z5hq3ZkPNCpZ to yKkNB9F8Hwnj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cbracken requested review from matanlurey and zanderso August 16, 2024 22:20

cbracken commented Aug 16, 2024

View reviewed changes

cbracken requested a review from jmagman August 16, 2024 22:22

matanlurey approved these changes Aug 16, 2024

View reviewed changes

cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 16, 2024

cbracken mentioned this pull request Aug 16, 2024

macOS: Extract framework creation to sky_utils #54586

Merged

8 tasks

cbracken force-pushed the fix-docs branch from 156eba0 to e5ee58b Compare August 16, 2024 22:30

jmagman approved these changes Aug 16, 2024

View reviewed changes

zanderso reviewed Aug 16, 2024

View reviewed changes

auto-submit bot merged commit 03543b2 into flutter:main Aug 16, 2024
24 checks passed

cbracken deleted the fix-docs branch August 16, 2024 23:39

engine-flutter-autoroll mentioned this pull request Aug 17, 2024

Roll Flutter Engine from c94651c33b0e to 8bcc17a87392 (2 revisions) flutter/flutter#153615

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2024

03543b2d7 [docs] Add missing steps to Testing Presubmit Engine PRs (f…

5a2f32e

…lutter/engine#54593)

engine-flutter-autoroll mentioned this pull request Aug 17, 2024

Roll Flutter Engine from c94651c33b0e to 7682457d1d85 (3 revisions) flutter/flutter#153617

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2024

03543b2d7 [docs] Add missing steps to Testing Presubmit Engine PRs (f…

896ef61

…lutter/engine#54593)

engine-flutter-autoroll mentioned this pull request Aug 17, 2024

Roll Flutter Engine from c94651c33b0e to c9fb47927fea (5 revisions) flutter/flutter#153618

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2024

03543b2d7 [docs] Add missing steps to Testing Presubmit Engine PRs (f…

33ad810

…lutter/engine#54593)

auto-submit bot mentioned this pull request Aug 17, 2024

Reverts "Roll Flutter Engine from c94651c33b0e to c9fb47927fea (5 revisions) (#153618)" flutter/flutter#153627

Merged

engine-flutter-autoroll mentioned this pull request Aug 17, 2024

Roll Flutter Engine from c94651c33b0e to b1384777eec8 (7 revisions) flutter/flutter#153636

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2024

03543b2d7 [docs] Add missing steps to Testing Presubmit Engine PRs (f…

a12aa1f

…lutter/engine#54593)

engine-flutter-autoroll mentioned this pull request Aug 17, 2024

Roll Flutter Engine from c94651c33b0e to b1384777eec8 (7 revisions) flutter/flutter#153642

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2024

03543b2d7 [docs] Add missing steps to Testing Presubmit Engine PRs (f…

6b44102

…lutter/engine#54593)

engine-flutter-autoroll mentioned this pull request Aug 17, 2024

Roll Flutter Engine from c94651c33b0e to b1384777eec8 (7 revisions) flutter/flutter#153643

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2024

03543b2d7 [docs] Add missing steps to Testing Presubmit Engine PRs (f…

ee3c3ef

…lutter/engine#54593)

engine-flutter-autoroll mentioned this pull request Aug 18, 2024

Roll Flutter Engine from c94651c33b0e to 2281ec864ca3 (8 revisions) flutter/flutter#153647

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2024

03543b2d7 [docs] Add missing steps to Testing Presubmit Engine PRs (f…

b4dbb14

…lutter/engine#54593)

engine-flutter-autoroll mentioned this pull request Aug 18, 2024

Roll Flutter Engine from c94651c33b0e to 2281ec864ca3 (8 revisions) flutter/flutter#153650

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2024

03543b2d7 [docs] Add missing steps to Testing Presubmit Engine PRs (f…

36bd6b8

…lutter/engine#54593)

engine-flutter-autoroll mentioned this pull request Aug 18, 2024

Roll Flutter Engine from c94651c33b0e to d0d7de5c333d (9 revisions) flutter/flutter#153652

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2024

03543b2d7 [docs] Add missing steps to Testing Presubmit Engine PRs (f…

7f129c6

…lutter/engine#54593)

engine-flutter-autoroll mentioned this pull request Aug 18, 2024

Roll Flutter Engine from c94651c33b0e to d0d7de5c333d (9 revisions) flutter/flutter#153654

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2024

03543b2d7 [docs] Add missing steps to Testing Presubmit Engine PRs (f…

d7590dc

…lutter/engine#54593)

engine-flutter-autoroll mentioned this pull request Aug 18, 2024

Roll Flutter Engine from c94651c33b0e to d0d7de5c333d (9 revisions) flutter/flutter#153657

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2024

03543b2d7 [docs] Add missing steps to Testing Presubmit Engine PRs (f…

8a72621

…lutter/engine#54593)

engine-flutter-autoroll mentioned this pull request Aug 18, 2024

Manual roll Flutter Engine from c94651c33b0e to d0d7de5c333d (9 revisions) flutter/flutter#153659

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2024

03543b2d7 [docs] Add missing steps to Testing Presubmit Engine PRs (f…

e2db78c

…lutter/engine#54593)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[docs] Add missing steps to Testing Presubmit Engine PRs #54593

[docs] Add missing steps to Testing Presubmit Engine PRs #54593

cbracken commented Aug 16, 2024

cbracken Aug 16, 2024 •

edited

Loading

jmagman Aug 16, 2024

cbracken Aug 16, 2024

zanderso Aug 16, 2024

cbracken Aug 16, 2024


		## 2. Wait

		Contemplate the nature of the universe or why it is that this workflow was necessary for your situation. Could tests have been added to the engine? If not, get youself some coffee and a cookie. You'll need them.

[docs] Add missing steps to Testing Presubmit Engine PRs #54593

[docs] Add missing steps to Testing Presubmit Engine PRs #54593

Conversation

cbracken commented Aug 16, 2024

Pre-launch Checklist

cbracken Aug 16, 2024 • edited Loading

Choose a reason for hiding this comment

jmagman Aug 16, 2024

Choose a reason for hiding this comment

cbracken Aug 16, 2024

Choose a reason for hiding this comment

zanderso Aug 16, 2024

Choose a reason for hiding this comment

cbracken Aug 16, 2024

Choose a reason for hiding this comment

cbracken Aug 16, 2024 •

edited

Loading