Skip to content

Add clipBehavior to DialogTheme #147634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ValentinVignal opened this issue May 1, 2024 · 1 comment · Fixed by #147635
Closed

Add clipBehavior to DialogTheme #147634

ValentinVignal opened this issue May 1, 2024 · 1 comment · Fixed by #147635
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version team-design Owned by Design Languages team triaged-design Triaged by Design Languages team

Comments

@ValentinVignal
Copy link
Contributor

Use case

Right now, we can specify the Clip clipBehavior of dialog when building them:

Dialog(
  clipBehavior: Clip.hardEdge,
);

It would be nice to be able to specify it in the theme so it applies to all dialogs in the app.

Proposal

Add a new property Clip? clipBehavior to DialogTheme that would be used by the dialogs.
@ValentinVignal ValentinVignal changed the title Add clipBehavior to DialogThem Add clipBehavior to DialogTheme May 1, 2024
@ValentinVignal ValentinVignal mentioned this issue May 1, 2024
Merged
9 tasks
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team c: new feature Nothing broken; request for a new capability framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. c: proposal A detailed proposal for a change to Flutter team-design Owned by Design Languages team and removed in triage Presently being triaged by the triage team labels May 2, 2024
@Piinks Piinks added P2 Important issues not at the top of the work list triaged-design Triaged by Design Languages team labels May 8, 2024
auto-submit bot pushed a commit that referenced this issue May 10, 2024
@ValentinVignal
Add clipBehavior to DialogTheme (#147635)
8e53ad9 
Fixes #147634
@danagbemava-nc danagbemava-nc added the r: fixed Issue is closed as already fixed in a newer version label May 13, 2024
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version team-design Owned by Design Languages team triaged-design Triaged by Design Languages team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add clipBehavior to DialogTheme ValentinVignal/flutter
3 participants
@Piinks @ValentinVignal @danagbemava-nc