Add clipBehavior to DialogTheme

[ValentinVignal]

Fixes #147634

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• I followed the breaking change policy and added Data Driven Fixes where supported.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[ValentinVignal]

I modified this one because the comment says it is hand-coded. I didn't modify the material 3 ones below because the comments say it is being generated.

@TahaTesser, can I ask what I should do ?

Should I

1. Not modify those default classes and leave the ?? Clip.none above in the code
2. Modify on M2 by hand (current state of this PR)
3. Modify M2 by and but also M3 (in which case, how to modify M3?)

?

[TahaTesser]

You can modify _DialogDefaultsM2 as well as _DialogDefaultsM3.

To update M3 defaults go to flutter/dev/tools/gen_defaults/lib/dialog_template.dart file and update the file as like this:

class _${blockName}DefaultsM3 extends DialogTheme {
  _${blockName}DefaultsM3(this.context)
    : super(
        alignment: Alignment.center,
        elevation: ${elevation("md.comp.dialog.container")},
        shape: ${shape("md.comp.dialog.container")},
+       clipBehavior: Clip.none,
      );

class DialogFullscreenTemplate extends TokenTemplate {
  const DialogFullscreenTemplate(super.blockName, super.fileName, super.tokens);

  @override
  String generate() => '''
class _${blockName}DefaultsM3 extends DialogTheme {
+  const _${blockName}DefaultsM3(this.context) : super(clipBehavior: Clip.none);

And generate the template following instructions in here

[ValentinVignal]

Great! Thank you for the help!

[ValentinVignal]

I'm not sure why the tests for the documentation fail, is there something I didn't do correctly?

[TahaTesser]

Thanks for the contribution! Looks like there are some minor issues to address.

[TahaTesser]

You can modify _DialogDefaultsM2 as well as _DialogDefaultsM3.

To update M3 defaults go to flutter/dev/tools/gen_defaults/lib/dialog_template.dart file and update the file as like this:

class _${blockName}DefaultsM3 extends DialogTheme {
  _${blockName}DefaultsM3(this.context)
    : super(
        alignment: Alignment.center,
        elevation: ${elevation("md.comp.dialog.container")},
        shape: ${shape("md.comp.dialog.container")},
+       clipBehavior: Clip.none,
      );

class DialogFullscreenTemplate extends TokenTemplate {
  const DialogFullscreenTemplate(super.blockName, super.fileName, super.tokens);

  @override
  String generate() => '''
class _${blockName}DefaultsM3 extends DialogTheme {
+  const _${blockName}DefaultsM3(this.context) : super(clipBehavior: Clip.none);

And generate the template following instructions in here

[ValentinVignal]

Thank you @TahaTesser for this very detailed review! Hopefully I fixed all the issues you found

[TahaTesser]

LGTM!

[bleroux]

Nice! One small typo to fix before approval.

[bleroux]

Suggested change

	/// the defaults to [Clip.none].
	/// defaults to [Clip.none].

[ValentinVignal]

Thanks for the review! I committed it in Update packages/flutter/lib/src/material/dialog.dart

[ValentinVignal]

Oh no! now the pipeline is failing because of your CLA @bleroux

[bleroux]

Oh no! now the pipeline is failing because of your CLA @bleroux

@ValentinVignal Oh, sorry for that, I just noticed that the GitHub web operations use the primary email address set in my GitHub account which is not the one I use for filing PR. I have updated it but this won't change this last commit on your PR.
So the solution I see is that you delete this last commit, create a similar one and force push. Really sorry for that 😅

[ValentinVignal]

Okay sure, I'll do that :)

[ValentinVignal]

It should be good to go now 👍

[bleroux]

LGTM!