Skip to content

[ci] Switch analyze tests to LUCI #4264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2023
Merged

[ci] Switch analyze tests to LUCI #4264

merged 2 commits into from
Jun 22, 2023

Conversation

stuartmorgan-g
Copy link
Contributor

Fully enables the new analyze and downgraded-analyze tests in LUCI, and removes the Cirrus versions.

Part of flutter/flutter#114373

@stuartmorgan-g
[ci] Switch analyze tests to LUCI
c859275 
Fully enables the new analyze and downgraded-analyze tests in LUCI, and
removes the Cirrus versions.

Part of flutter/flutter#114373
@stuartmorgan-g stuartmorgan-g force-pushed the ci-luci-analyze-switch branch from feba38e to c859275 Compare June 21, 2023 14:03
keyonghan
keyonghan approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Contributor Author

Hm, looks like this is too slow on the full-repo run. Can we easily see what the gating factor is here (CPU? Memory?)

@keyonghan
Copy link
Contributor

Hm, looks like this is too slow on the full-repo run. Can we easily see what the gating factor is here (CPU? Memory?)

All linux VMs are configured the same way though. Couldn't tell why it's slow compared to a passing build.

Btw:
flutter/flutter#125577 to collect os/cpu info for packages targets.
flutter/flutter#129291 to route all Linux targets to VMs.

@stuartmorgan-g
Copy link
Contributor Author

Oh, looking again I don't think it's slow, I think it hung. Maybe a server-side resolver problem or network issue?

Comparing the relative time offsets in the logging, the one that didn't finish and the one that did both got through shared_preferences by about minute 9, but then the failing one just never got any further than than (at least, not that was logged).

@stuartmorgan-g
Copy link
Contributor Author

Looks like the Cirrus repo_checks failure is also a timeout, which is more evidence for some kind of external bad event.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 21, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 21, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 21, 2023

auto label is removed for flutter/packages, pr: 4264, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 22, 2023

auto label is removed for flutter/packages, pr: 4264, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2023
@auto-submit auto-submit bot merged commit 95bc1c6 into flutter:main Jun 22, 2023
@stuartmorgan-g stuartmorgan-g deleted the ci-luci-analyze-switch branch June 22, 2023 10:51
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 22, 2023
@engine-flutter-autoroll
95bc1c6 [ci] Switch analyze tests to LUCI (flutter/packages#4264)
19a3c10
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 22, 2023
@engine-flutter-autoroll
Roll Packages from 9af50d4 to 95bc1c6 (6 revisions) (#129351)
419bf81 
flutter/packages@9af50d4...95bc1c6

2023-06-22 [email protected] [ci] Switch analyze tests to LUCI (flutter/packages#4264)
2023-06-22 [email protected] Roll Flutter from fc8856e to c40baf4 (57 revisions) (flutter/packages#4270)
2023-06-22 [email protected] [ci] Add LUCI version of build-all for Android (flutter/packages#4236)
2023-06-21 [email protected] [go_router] Adds parent navigator key to ShellRoute and StatefulShellâ�¦ (flutter/packages#4201)
2023-06-21 [email protected] [pigeon] Add macOS Obj-C support (flutter/packages#4267)
2023-06-21 [email protected] [tools] Fix format instructions (flutter/packages#4259)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

@yusuf-goog yusuf-goog Awaiting requested review from yusuf-goog

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan-g @keyonghan