Skip to content

[ci] Switch analyze tests to LUCI #4264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,15 @@ targets:
version_file: flutter_master.version

- name: Linux analyze master
bringup: true # New target
recipe: packages/packages
timeout: 30
properties:
add_recipes_cq: "true"
target_file: analyze.yaml
channel: master
version_file: flutter_master.version

- name: Linux analyze stable
bringup: true # New target
recipe: packages/packages
timeout: 30
properties:
Expand All @@ -98,16 +97,15 @@ targets:
version_file: flutter_stable.version

- name: Linux analyze_downgraded master
bringup: true # New target
recipe: packages/packages
timeout: 30
properties:
add_recipes_cq: "true"
target_file: analyze_downgraded.yaml
channel: master
version_file: flutter_master.version

- name: Linux analyze_downgraded stable
bringup: true # New target
recipe: packages/packages
timeout: 30
properties:
Expand Down
33 changes: 0 additions & 33 deletions .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,30 +115,6 @@ task:
- else
- ./script/tool_runner.sh federation-safety-check
- fi
- name: analyze
env:
matrix:
CHANNEL: "master"
CHANNEL: "stable"
analyze_tool_script:
- cd script/tool
- dart analyze --fatal-infos
analyze_script:
# DO NOT change the custom-analysis argument here without changing the Dart repo.
# See the comment in script/configs/custom_analysis.yaml for details.
- ./script/tool_runner.sh analyze --custom-analysis=script/configs/custom_analysis.yaml
pathified_analyze_script:
# Re-run analysis with path-based dependencies to ensure that publishing
# the changes won't break analysis of other packages in the respository
# that depend on it.
- ./script/tool_runner.sh make-deps-path-based --target-dependencies-with-non-breaking-updates
# This uses --run-on-dirty-packages rather than --packages-for-branch
# since only the packages changed by 'make-deps-path-based' need to be
# checked.
- $PLUGIN_TOOL_COMMAND analyze --run-on-dirty-packages --log-timing --custom-analysis=script/configs/custom_analysis.yaml
# Restore the tree to a clean state, to avoid accidental issues if
# other script steps are added to this task.
- git checkout .
# Does a sanity check that packages at least pass analysis on the N-1 and N-2
# versions of Flutter stable if the package claims to support that version.
# This is to minimize accidentally making changes that break old versions
Expand All @@ -147,7 +123,6 @@ task:
# Note: The versions below should be manually updated after a new stable
# version comes out.
- name: legacy_version_analyze
depends_on: analyze
matrix:
# Change the arguments to pubspec-check when changing these values.
env:
Expand All @@ -164,14 +139,6 @@ task:
# Only analyze lib/; non-client code doesn't need to work on
# all supported legacy version.
- ./script/tool_runner.sh analyze --lib-only --skip-if-not-supporting-flutter-version="$CHANNEL" --skip-if-not-supporting-dart-version="$DART_VERSION" --custom-analysis=script/configs/custom_analysis.yaml
# Does a sanity check that packages pass analysis with the lowest possible
# versions of all dependencies. This is to catch cases where we add use of
# new APIs but forget to update minimum versions of dependencies to where
# those APIs are introduced.
- name: downgraded_analyze
depends_on: analyze
analyze_script:
- ./script/tool_runner.sh analyze --downgrade --custom-analysis=script/configs/custom_analysis.yaml
- name: readme_excerpts
env:
CIRRUS_CLONE_SUBMODULES: true
Expand Down