[tool] Add support for using a Kotlin test runner file #6131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
bparrishMines
changed the title
| }, | ||
| ); | ||
|
|
||
| expect(commandError, isNull); |
There was a problem hiding this comment.
Generally when we don't expect a failure we just don't pass errorHandler or declare commandError, since if it throws without an error handler the test will fail.
I often like to check for Ran for 1 package in the output as the affirmative test, because then it can't accidentally pass by not having the package picked up somehow.
stuartmorgan-g
approved these changes
Feb 15, 2024
tarrinneal
approved these changes
Feb 15, 2024
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 16, 2024
flutter/packages@ef349be...c56c12d 2024-02-16 [email protected] [tool] Add support for using a Kotlin test runner file (flutter/packages#6131) 2024-02-16 [email protected] [in_app_purchase] fix skerror nullability (flutter/packages#6139) 2024-02-15 [email protected] Explicitly pass the web renderer into the tests. (flutter/packages#6140) 2024-02-15 [email protected] [google_sign_in] Clean up pre-Pigeon code (flutter/packages#6141) 2024-02-15 [email protected] [local_auth] Add compatibility with latest `intl` (flutter/packages#6138) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.