Explicitly pass the web renderer into the tests. #6140
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This tooling has unit test, so this will need a test. @ditman It seems like we have a coverage problem here; is there an issue tracking the fact that we are only testing with one renderer? |
|
@stuartmorgan I went ahead and filed flutter/flutter#143543 |
Probably a good idea. Let me look |
eyebrowsoffire
added
the
autosubmit
flutter/packages@ef349be...c56c12d 2024-02-16 [email protected] [tool] Add support for using a Kotlin test runner file (flutter/packages#6131) 2024-02-16 [email protected] [in_app_purchase] fix skerror nullability (flutter/packages#6139) 2024-02-15 [email protected] Explicitly pass the web renderer into the tests. (flutter/packages#6140) 2024-02-15 [email protected] [google_sign_in] Clean up pre-Pigeon code (flutter/packages#6141) 2024-02-15 [email protected] [local_auth] Add compatibility with latest `intl` (flutter/packages#6138) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The web tests currently all assume to be using the html renderer. `flutter test` previously erroneously was serving files for the HTML renderer by default (which is not the intended behavior). After this was fixed, the tests started running on the CanvasKit renderer and some of them broke. If we are relying on the html renderer, we should explicitly pass it when running `flutter test`
The web tests currently all assume to be using the html renderer.
flutter testpreviously erroneously was serving files for the HTML renderer by default (which is not the intended behavior). After this was fixed, the tests started running on the CanvasKit renderer and some of them broke. If we are relying on the html renderer, we should explicitly pass it when runningflutter test