Update multiple packages to depend on versions with iOS privacy manifest included #6355

vbuberen · 2024-03-19T10:37:22Z

Updated multiple packages pubspec.yaml to depend on iOS implementation versions that include privacy manifest required by Apple. I touched packages that were referenced in flutter/flutter#131940 issue.
The reason to do this change is that in a few projects I noticed that updating url_launcher dependency to the currently latest 6.2.5 doesn't also update url_launcher_ios to version with privacy manifest (appeared in 6.2.4) included in the plugin's pubspec.yaml it is declared as ^6.2.0, thus, version resolution picks 6.2.0 and that is it.

Considering that there is already a deadline of May 1, 2024 from Apple on when apps would have to include privacy manifests, it would be good to let devs already prepare their projects. This change should be especially useful for shared_preferences, which has NSPrivacyAccessedAPITypes array declared in its privacy manifest and which is already asked by Apple in emails after uploading new builds:

Didn't update changelogs due to the fact that plugins stayed in almost the same versions range, where those minor changes to iOS part had no serious changed.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

stuartmorgan-g · 2024-03-19T11:25:43Z

Normally we don't impose version constraints that aren't required by the code, but we have precendent for doing this when there's a store-level requirement that is imposed, so this seems reasonable.

in the plugin's pubspec.yaml it is declared as ^6.2.0, thus, version resolution picks 6.2.0 and that is it.

Version resolution will pick the newest version it can. The reason existing projects don't get updated versions of url_launcher_ios when just changing url_launcher's version manually is pubspec.lock, not that the resolver won't give newer versions.

it would be good to let devs already prepare their projects

Devs can already prepare their projects simply by running flutter pub upgrade. We can in practice speed the update process due to many people choosing for some reason to only update their direct dependencies rather than also updating their transitive dependencies, but developers could (and should) update transitive dependencies without any change by us.

Didn't update changelogs due to the fact that plugins stayed in almost the same versions range, where those minor changes to iOS part had no serious changed.

What is the purpose of changing the constraints without publishing that change?

vbuberen · 2024-03-19T12:06:51Z

Version resolution will pick the newest version it can. The reason existing projects don't get updated versions of url_launcher_ios when just changing url_launcher's version manually is pubspec.lock, not that the resolver won't give newer versions.

Alright, got it. In such case I have a few projects with some limitations. And yes, it is manual change of version in pubspec.yaml + click on Get button in the IDE. I know quite a lot of people who do updates the same way, not just my direct colleagues, so this PR is something that would help ensure that such people also get updated versions resolved when next releases of touched plugins will be released.

Devs can already prepare their projects simply by running flutter pub upgrade.

I think you meant flutter pub upgrade [dependency name] as there are enough projects with a huge set of dependencies where it is not the best option to run an upgrade for everything instead of doing part by part for smaller set of changes.

What is the purpose of changing the constraints without publishing that change?

You misunderstood my message. The change needs publishing. The thing is that those versions of iOS part were compatible already before, so this bump doesn't change much and, thus, from my point of view is not something worth mentioning separately.

But in general it seems like changes from this PR are unwanted . You could just reject the PR with request for changes if you expect some or close it instead.

stuartmorgan-g · 2024-03-19T13:30:36Z

Devs can already prepare their projects simply by running flutter pub upgrade.

I think you meant flutter pub upgrade [dependency name] as there are enough projects with a huge set of dependencies where it is not the best option to run an upgrade for everything instead of doing part by part for smaller set of changes.

In this case I do mean flutter pub upgrade. I expect most developers have multiple transitive dependencies that they will need to update to comply with the new App Store polices, and tracking down all of the relevant transitive dependencies one at a time by hand is likely to be pretty painful. Obviously it's their choice either way though.

But in general it seems like changes from this PR are unwanted

No, as I said we have precedent for doing this kind of change specifically in the case of app store requirements. I was just clarifying the context/reason we would accept it, since the PR description suggested that this change was required in order for clients to update, which isn't actually the case. I clarify this whenever anyone says it in any PR or issue, because it's a relatively common misconception, and my hope is that the more places it's corrected, the less widespread the misconception will be.

stuartmorgan-g

I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.

I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.

These steps are required for the PR to land.

stuartmorgan-g · 2024-03-25T00:21:16Z

packages/video_player/video_player/pubspec.yaml

@@ -3,7 +3,7 @@ description: Flutter plugin for displaying inline video with other Flutter
  widgets on Android, iOS, and web.
 repository: https://github.com/flutter/packages/tree/main/packages/video_player/video_player
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22
-version: 2.8.3
+version: 2.8.4

 environment:
  sdk: ">=3.1.0 <4.0.0"


These two values need to be rev'd to fix this failure; the package currently fails resolution on 3.13.

I see that video_player_avfoundation has higher min Flutter + Dart, so updated constraints here, in video_player, to match.

stuartmorgan-g · 2024-03-25T00:23:18Z

packages/image_picker/image_picker/CHANGELOG.md


 * Updates minimum supported SDK version to Flutter 3.13/Dart 3.1.
 * Updates support matrix in README to indicate that iOS 11 is no longer supported.
 * Clients on versions of Flutter that still support iOS 11 can continue to use this
  package with iOS 11, but will not receive any further updates to the iOS implementation.
+* Bumps min version of iOS part to start with version with privacy manifest included.


I'm having trouble parsing this (I'm not sure what it means for the minimum version of something to start with something means). How about:

Updates minimum iOS implementation version to include a privacy manifest.

(This applies throughout the PR.)

vbuberen · 2024-04-02T19:43:38Z

@stuartmorgan Would you mind checking this PR again?

The failing integration test is something I can't tackle as locally this test passes Ok for me in my setup with Android emulators. I see that the reason for failing on CI is in some small time diff in position, which seems a bit odd: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8751747162297807793/+/u/Run_package_tests/drive_examples/stdout#L23859_0
I saw this issue flutter/flutter#141145 and the comment so assume that this test is expected to be flaky, even though previously there was a different issue with it?

stuartmorgan-g

LGTM

stuartmorgan-g · 2024-04-05T10:48:08Z

@tarrinneal Could you do the secondary review here?

(This will need conflicts resolved, but that can wait until it has all the reviews so that it doesn't get re-conflicted.)

vbuberen · 2024-04-11T15:29:39Z

@stuartmorgan Looks like this one can be merged. Second approve is done and I have already updated the branch to resolve conflicts.

…cy manifest included (flutter/packages#6355)

flutter/packages@e98839a...78f684c 2024-04-12 [email protected] Roll Flutter from 557fbf5 to 53cba24 (11 revisions) (flutter/packages#6509) 2024-04-11 [email protected] [file_selector] Remove OCMock from iOS implementation (flutter/packages#6503) 2024-04-11 [email protected] Access current location using uri.path to support deep links (flutter/packages#6474) 2024-04-11 [email protected] Roll Flutter from 97cd47a to 557fbf5 (22 revisions) (flutter/packages#6502) 2024-04-11 [email protected] [packages] Set parallelizable to NO to reduce test flakiness in packages project tests (flutter/packages#6471) 2024-04-11 [email protected] Update multiple packages to depend on versions with iOS privacy manifest included (flutter/packages#6355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

- Updates the README to indicate that iOS 12 and 13 are no longer supported. - Updates the minimum version of the iOS implementation package to one with privacy manifest support. See related discussion in flutter#6355

- Updates the README to indicate that iOS 12 and 13 are no longer supported. - Updates the minimum version of the iOS implementation package to one with privacy manifest support. See related discussion in #6355

flutter/packages@e98839a...78f684c 2024-04-12 [email protected] Roll Flutter from 557fbf5 to 53cba24 (11 revisions) (flutter/packages#6509) 2024-04-11 [email protected] [file_selector] Remove OCMock from iOS implementation (flutter/packages#6503) 2024-04-11 [email protected] Access current location using uri.path to support deep links (flutter/packages#6474) 2024-04-11 [email protected] Roll Flutter from 97cd47a to 557fbf5 (22 revisions) (flutter/packages#6502) 2024-04-11 [email protected] [packages] Set parallelizable to NO to reduce test flakiness in packages project tests (flutter/packages#6471) 2024-04-11 [email protected] Update multiple packages to depend on versions with iOS privacy manifest included (flutter/packages#6355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…est included (flutter#6355) Updated multiple packages `pubspec.yaml` to depend on iOS implementation versions that include privacy manifest required by Apple. I touched packages that were referenced in flutter/flutter#131940 issue. The reason to do this change is that in a few projects I noticed that updating `url_launcher` dependency to the currently latest 6.2.5 doesn't also update `url_launcher_ios` to version with privacy manifest (appeared in 6.2.4) included in the plugin's `pubspec.yaml` it is declared as `^6.2.0`, thus, version resolution picks 6.2.0 and that is it. Considering that there is already a deadline of May 1, 2024 from Apple on when apps would have to include privacy manifests, it would be good to let devs already prepare their projects. This change should be especially useful for `shared_preferences`, which has `NSPrivacyAccessedAPITypes` array declared in its privacy manifest and which is already asked by Apple in emails after uploading new builds: <img width="681" alt="Screenshot 2024-03-19 at 12 36 47" src="https://github.com/flutter/packages/assets/13467769/c81e5a15-86d8-4270-aafe-845679fc901b"> Didn't update changelogs due to the fact that plugins stayed in almost the same versions range, where those minor changes to iOS part had no serious changed.

…tter#6552) - Updates the README to indicate that iOS 12 and 13 are no longer supported. - Updates the minimum version of the iOS implementation package to one with privacy manifest support. See related discussion in flutter#6355

…est included (flutter#6355) Updated multiple packages `pubspec.yaml` to depend on iOS implementation versions that include privacy manifest required by Apple. I touched packages that were referenced in flutter/flutter#131940 issue. The reason to do this change is that in a few projects I noticed that updating `url_launcher` dependency to the currently latest 6.2.5 doesn't also update `url_launcher_ios` to version with privacy manifest (appeared in 6.2.4) included in the plugin's `pubspec.yaml` it is declared as `^6.2.0`, thus, version resolution picks 6.2.0 and that is it. Considering that there is already a deadline of May 1, 2024 from Apple on when apps would have to include privacy manifests, it would be good to let devs already prepare their projects. This change should be especially useful for `shared_preferences`, which has `NSPrivacyAccessedAPITypes` array declared in its privacy manifest and which is already asked by Apple in emails after uploading new builds: <img width="681" alt="Screenshot 2024-03-19 at 12 36 47" src="https://github.com/flutter/packages/assets/13467769/c81e5a15-86d8-4270-aafe-845679fc901b"> Didn't update changelogs due to the fact that plugins stayed in almost the same versions range, where those minor changes to iOS part had no serious changed.

…tter#6552) - Updates the README to indicate that iOS 12 and 13 are no longer supported. - Updates the minimum version of the iOS implementation package to one with privacy manifest support. See related discussion in flutter#6355

vbuberen requested review from tarrinneal and stuartmorgan-g as code owners March 19, 2024 10:37

github-actions bot added p: image_picker p: path_provider p: video_player p: url_launcher p: shared_preferences labels Mar 19, 2024

stuartmorgan-g requested changes Mar 19, 2024

View reviewed changes

vbuberen requested a review from stuartmorgan-g March 20, 2024 15:10

vbuberen force-pushed the fix/privacy_manifests branch from 04a58f6 to 22797c1 Compare March 20, 2024 20:24

stuartmorgan-g requested changes Mar 25, 2024

View reviewed changes

vbuberen force-pushed the fix/privacy_manifests branch from fcbcd10 to 6360209 Compare March 25, 2024 12:42

vbuberen requested a review from stuartmorgan-g March 25, 2024 12:42

vbuberen mentioned this pull request Mar 25, 2024

[Bug]: Create ITMS privacy manifest for Apple builds fluttercommunity/plus_plugins#2751

Closed

8 tasks

stuartmorgan-g mentioned this pull request Mar 26, 2024

[google_sign_in] Update GoogleSignIn iOS pod version to use one with a privacy manifest flutter/flutter#145777

Closed

vbuberen force-pushed the fix/privacy_manifests branch from 6360209 to 9c5bcc7 Compare April 2, 2024 17:55

stuartmorgan-g approved these changes Apr 5, 2024

View reviewed changes

tarrinneal approved these changes Apr 8, 2024

View reviewed changes

Update multiple packages to include iOS privacy manifest

17fcaa8

vbuberen force-pushed the fix/privacy_manifests branch from 9c5bcc7 to 17fcaa8 Compare April 9, 2024 17:10

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2024

auto-submit bot merged commit a21a447 into flutter:main Apr 11, 2024
78 checks passed

vbuberen deleted the fix/privacy_manifests branch April 11, 2024 17:31

engine-flutter-autoroll mentioned this pull request Apr 12, 2024

Roll Packages from e98839a9b8de to 03d34e215a85 (5 revisions) flutter/flutter#146689

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2024

a21a447 Update multiple packages to depend on versions with iOS priva…

26dea90

…cy manifest included (flutter/packages#6355)

engine-flutter-autoroll mentioned this pull request Apr 12, 2024

Roll Packages from e98839a9b8de to 78f684ce6771 (6 revisions) flutter/flutter#146691

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2024

a21a447 Update multiple packages to depend on versions with iOS priva…

f1a4126

…cy manifest included (flutter/packages#6355)

stuartmorgan-g mentioned this pull request Apr 17, 2024

[google_maps_flutter] Update app-facing package iOS requirements #6552

Merged

11 tasks

vbuberen mentioned this pull request Oct 27, 2024

[video_player] Bump min Android implementation version for better Java compatibility #7938

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update multiple packages to depend on versions with iOS privacy manifest included #6355

Update multiple packages to depend on versions with iOS privacy manifest included #6355

vbuberen commented Mar 19, 2024 •

edited

Loading

stuartmorgan-g commented Mar 19, 2024

vbuberen commented Mar 19, 2024

stuartmorgan-g commented Mar 19, 2024

stuartmorgan-g left a comment

stuartmorgan-g Mar 25, 2024

vbuberen Mar 25, 2024

stuartmorgan-g Mar 25, 2024

vbuberen commented Apr 2, 2024

stuartmorgan-g left a comment

stuartmorgan-g commented Apr 5, 2024

vbuberen commented Apr 11, 2024

Update multiple packages to depend on versions with iOS privacy manifest included #6355

Update multiple packages to depend on versions with iOS privacy manifest included #6355

Conversation

vbuberen commented Mar 19, 2024 • edited Loading

Pre-launch Checklist

stuartmorgan-g commented Mar 19, 2024

vbuberen commented Mar 19, 2024

stuartmorgan-g commented Mar 19, 2024

stuartmorgan-g left a comment

Choose a reason for hiding this comment

stuartmorgan-g Mar 25, 2024

Choose a reason for hiding this comment

vbuberen Mar 25, 2024

Choose a reason for hiding this comment

stuartmorgan-g Mar 25, 2024

Choose a reason for hiding this comment

vbuberen commented Apr 2, 2024

stuartmorgan-g left a comment

Choose a reason for hiding this comment

stuartmorgan-g commented Apr 5, 2024

vbuberen commented Apr 11, 2024

vbuberen commented Mar 19, 2024 •

edited

Loading