Skip to content

[google_maps_flutter] Update app-facing package iOS requirements #6552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2024
Merged

[google_maps_flutter] Update app-facing package iOS requirements #6552

merged 1 commit into from
Apr 17, 2024

Conversation

stuartmorgan-g
Copy link
Contributor

Pre-launch Checklist

@stuartmorgan-g
[google_maps_flutter] Update app-facing package iOS requirements
fc44439 
- Updates the README to indicate that iOS 12 and 13 are no longer
  supported.
- Updates the minimum version of the iOS implementation package to one
  with privacy manifest support. See related discussion in
  flutter#6355
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan-g
Copy link
Contributor Author

This will fix the OOB breakage in the tree, which I created by not changing this example app in the same PR where I changed google_maps_flutter_ios in a way that we knew would break apps that were still supporting iOS 12 🤦🏻

@stuartmorgan-g
Copy link
Contributor Author

test-exempt: configuration change

@stuartmorgan-g stuartmorgan-g added emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. autosubmit Merge PR when tree becomes green via auto submit App labels Apr 17, 2024
@auto-submit auto-submit bot merged commit 76c4a3d into flutter:main Apr 17, 2024
77 of 78 checks passed
@stuartmorgan-g stuartmorgan-g deleted the maps-ios-14-requirement-update branch April 17, 2024 15:08
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 18, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 18, 2024
@engine-flutter-autoroll
76c4a3d [google_maps_flutter] Update app-facing package iOS requireme…
1f71d7a 
…nts (flutter/packages#6552)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 18, 2024
@engine-flutter-autoroll
Roll Packages from d39830e to 0e3809d (9 revisions) (#146992)
af06493 
flutter/packages@d39830e...0e3809d

2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/packages#6562)
2024-04-18 [email protected] [ci] Add Linux desktop support to Linux custom_package_tests (flutter/packages#6551)
2024-04-17 [email protected] [two_dimensional_scrollables] Refactor Spans for common use (flutter/packages#6550)
2024-04-17 [email protected] [in_app_purchase] Add api to expose country code (flutter/packages#6540)
2024-04-17 [email protected] [camera] Initial iOS Pigeon conversion (flutter/packages#6553)
2024-04-17 [email protected] [in_app_purchase] Add countryCode implementation to android and storekit (flutter/packages#6556)
2024-04-17 [email protected] [google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 (flutter/packages#6404)
2024-04-17 [email protected] [in_app_purchase_platform_interface] Adds countryCode API (flutter/packages#6548)
2024-04-17 [email protected] [google_maps_flutter] Update app-facing package iOS requirements (flutter/packages#6552)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
@engine-flutter-autoroll @gilnobrega
Roll Packages from d39830e to 0e3809d (9 revisions) (flutter#146992)
2d5fb1e 
flutter/packages@d39830e...0e3809d

2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/packages#6562)
2024-04-18 [email protected] [ci] Add Linux desktop support to Linux custom_package_tests (flutter/packages#6551)
2024-04-17 [email protected] [two_dimensional_scrollables] Refactor Spans for common use (flutter/packages#6550)
2024-04-17 [email protected] [in_app_purchase] Add api to expose country code (flutter/packages#6540)
2024-04-17 [email protected] [camera] Initial iOS Pigeon conversion (flutter/packages#6553)
2024-04-17 [email protected] [in_app_purchase] Add countryCode implementation to android and storekit (flutter/packages#6556)
2024-04-17 [email protected] [google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 (flutter/packages#6404)
2024-04-17 [email protected] [in_app_purchase_platform_interface] Adds countryCode API (flutter/packages#6548)
2024-04-17 [email protected] [google_maps_flutter] Update app-facing package iOS requirements (flutter/packages#6552)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@stuartmorgan-g @TecHaxter
[google_maps_flutter] Update app-facing package iOS requirements (flu…
3370141 
…tter#6552)

- Updates the README to indicate that iOS 12 and 13 are no longer supported.
- Updates the minimum version of the iOS implementation package to one with privacy manifest support. See related discussion in flutter#6355
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@stuartmorgan-g @arc-yong
[google_maps_flutter] Update app-facing package iOS requirements (flu…
176ea04 
…tter#6552)

- Updates the README to indicate that iOS 12 and 13 are no longer supported.
- Updates the minimum version of the iOS implementation package to one with privacy manifest support. See related discussion in flutter#6355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

@cbracken cbracken Awaiting requested review from cbracken

@jmagman jmagman Awaiting requested review from jmagman

@tarrinneal tarrinneal Awaiting requested review from tarrinneal

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. p: google_maps_flutter platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan-g @reidbaker