Skip to content

[go_router] docs: replace out dated initialRoute to initialLocation #7147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

unliar
Copy link
Contributor

@unliar unliar commented Jul 17, 2024

‌‌‌‌Updated the outdated configurations in upgrading.md.

@unliar unliar requested a review from chunhtai as a code owner July 17, 2024 03:54
Copy link

google-cla bot commented Jul 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chunhtai
Copy link
Contributor

can you bump the version and add changelog?

@unliar
Copy link
Contributor Author

unliar commented Jul 19, 2024

can you bump the version and add changelog?

It has been supplemented.

@chunhtai
Copy link
Contributor

Also we should use code-excerpt for code in md file as well. you can find some example by searching <?code-excerpt

@chunhtai
Copy link
Contributor

edit: looks like the code excerpt support is only for readme.

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai requested a review from hannah-hyj August 14, 2024 19:37
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 16, 2024
@auto-submit auto-submit bot merged commit 7c1a05c into flutter:main Aug 16, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 19, 2024
flutter/packages@2c37fb0...7c1a05c

2024-08-16 [email protected] [go_router] docs: replace out dated initialRoute to initialLocation (flutter/packages#7147)
2024-08-16 [email protected] [interactive_media_ads] Updates readme to clarify currently supported features (flutter/packages#7398)
2024-08-16 [email protected] Roll Flutter from bced008 to a0c0453 (5 revisions) (flutter/packages#7429)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@2c37fb0...7c1a05c

2024-08-16 [email protected] [go_router] docs: replace out dated initialRoute to initialLocation (flutter/packages#7147)
2024-08-16 [email protected] [interactive_media_ads] Updates readme to clarify currently supported features (flutter/packages#7398)
2024-08-16 [email protected] Roll Flutter from bced008 to a0c0453 (5 revisions) (flutter/packages#7429)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: go_router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants