-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[go_router] docs: replace out dated initialRoute to initialLocation #7147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
can you bump the version and add changelog? |
It has been supplemented. |
Also we should use code-excerpt for code in md file as well. you can find some example by searching |
edit: looks like the code excerpt support is only for readme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/packages@2c37fb0...7c1a05c 2024-08-16 [email protected] [go_router] docs: replace out dated initialRoute to initialLocation (flutter/packages#7147) 2024-08-16 [email protected] [interactive_media_ads] Updates readme to clarify currently supported features (flutter/packages#7398) 2024-08-16 [email protected] Roll Flutter from bced008 to a0c0453 (5 revisions) (flutter/packages#7429) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@2c37fb0...7c1a05c 2024-08-16 [email protected] [go_router] docs: replace out dated initialRoute to initialLocation (flutter/packages#7147) 2024-08-16 [email protected] [interactive_media_ads] Updates readme to clarify currently supported features (flutter/packages#7398) 2024-08-16 [email protected] Roll Flutter from bced008 to a0c0453 (5 revisions) (flutter/packages#7429) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Updated the outdated configurations in upgrading.md.