[interactive_media_ads] Updates readme to clarify currently supported features #7398
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
cc @harold1208 |
bparrishMines
changed the title
| **This package is still in development.** | ||
| **NOTE:** | ||
| * The initial release for this package supports linear pre-roll video ads on iOS and Android | ||
| * platforms. Please view/report any issues [here](https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+interactive_media_ads%22). |
There was a problem hiding this comment.
What's the reason for the issue link? We have the metadata set that causes pub.dev to put an issues link in the sidebar, and that's where we expect clients to be seeing the README.
There was a problem hiding this comment.
Ah, that's right. That was my suggestion. I forgot that is already included in the pubspec. I removed it from here.
cc @harold1208 to confirm this is fine as well
bparrishMines
added
the
autosubmit
flutter/packages@2c37fb0...7c1a05c 2024-08-16 [email protected] [go_router] docs: replace out dated initialRoute to initialLocation (flutter/packages#7147) 2024-08-16 [email protected] [interactive_media_ads] Updates readme to clarify currently supported features (flutter/packages#7398) 2024-08-16 [email protected] Roll Flutter from bced008 to a0c0453 (5 revisions) (flutter/packages#7429) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@2c37fb0...7c1a05c 2024-08-16 [email protected] [go_router] docs: replace out dated initialRoute to initialLocation (flutter/packages#7147) 2024-08-16 [email protected] [interactive_media_ads] Updates readme to clarify currently supported features (flutter/packages#7398) 2024-08-16 [email protected] Roll Flutter from bced008 to a0c0453 (5 revisions) (flutter/packages#7429) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.