Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] delete original file if scaled #1288

Merged
merged 4 commits into from
Mar 11, 2019
Merged

[image_picker] delete original file if scaled #1288

merged 4 commits into from
Mar 11, 2019

Conversation

ivk1800
Copy link
Contributor

@ivk1800 ivk1800 commented Feb 27, 2019

@ivk1800 ivk1800 mentioned this pull request Mar 6, 2019
Merged
cyanglaz
cyanglaz suggested changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Please add the versioning update following the rules here https://www.dartlang.org/tools/pub/versioning#semantic-versions

cyanglaz
cyanglaz suggested changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit change.

packages/image_picker/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 0.5.0+4

* Deleting original image if image was scaled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT:

Suggested change
* Deleting original image if image was scaled
* Delete the original image if it was scaled.

cyanglaz
cyanglaz approved these changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you so much again for the contribution.
There seems to be some conflicts of the PR. If you'd like to resolve the conflicts, I can merge it after.

@ivk1800 ivk1800 force-pushed the delete_original_file_after_scaling branch from 88700eb to 6fdf2fc Compare March 11, 2019 18:58
@ivk1800
Copy link
Contributor Author

ivk1800 commented Mar 11, 2019

@cyanglaz done! I forgot rebase my master to upstream

@cyanglaz cyanglaz merged commit 4b24153 into flutter:master Mar 11, 2019
This was referenced Mar 11, 2019
Closed
Closed
@microdog microdog mentioned this pull request Mar 20, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

image_picker: original image taken from camera won't be removed after imageResizer.resizeImageIfNeeded on Android
3 participants
@ivk1800 @cyanglaz @googlebot