-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[image_picker] delete original file if scaled #1288
[image_picker] delete original file if scaled #1288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Please add the versioning update following the rules here https://www.dartlang.org/tools/pub/versioning#semantic-versions
...s/image_picker/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit change.
packages/image_picker/CHANGELOG.md
Outdated
@@ -1,3 +1,7 @@ | |||
## 0.5.0+4 | |||
|
|||
* Deleting original image if image was scaled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT:
* Deleting original image if image was scaled | |
* Delete the original image if it was scaled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you so much again for the contribution.
There seems to be some conflicts of the PR. If you'd like to resolve the conflicts, I can merge it after.
88700eb
to
6fdf2fc
Compare
@cyanglaz done! I forgot rebase my master to upstream |
fixed flutter/flutter#23500