Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] delete original file if scaled #1288

Merged
merged 4 commits into from
Mar 11, 2019

Conversation

ivk1800
Copy link
Contributor

@ivk1800 ivk1800 commented Feb 27, 2019

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Please add the versioning update following the rules here https://www.dartlang.org/tools/pub/versioning#semantic-versions

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit change.

@@ -1,3 +1,7 @@
## 0.5.0+4

* Deleting original image if image was scaled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT:

Suggested change
* Deleting original image if image was scaled
* Delete the original image if it was scaled.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you so much again for the contribution.
There seems to be some conflicts of the PR. If you'd like to resolve the conflicts, I can merge it after.

@ivk1800 ivk1800 force-pushed the delete_original_file_after_scaling branch from 88700eb to 6fdf2fc Compare March 11, 2019 18:58
@ivk1800
Copy link
Contributor Author

ivk1800 commented Mar 11, 2019

@cyanglaz done! I forgot rebase my master to upstream

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

image_picker: original image taken from camera won't be removed after imageResizer.resizeImageIfNeeded on Android
3 participants