This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] remove unnecessary file path for video. #1315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems related #1288 |
|
The tmp path logic was added in https://github.com/flutter/image_picker/commit/5409baccb75680547b1a799f6853da423e5fd9cb @collinjackson do you know whether we still need it? |
|
The original videoURL is already a tmpPath. I thought adding another tmpPath did not make sense. I guess it could be a copy paste error (copy pasted from the picking image logic) when we introduced the video capability in the plugin. |
cyanglaz
added
needs love
submit queue
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified version of #1245 fix.
When pick videos, we used to create an unnecessary extra file. This PR removes the extra temp file logic.