[google_sign_in] Add implementations for new Oauth scope methods. #2562

emerssso · 2020-02-27T04:13:45Z

Description

Adds two new methods, hasGrantedScope and requestScope, to the GoogleSginIn implementations for Android, iOS, and web.

Related Issues

Allow requesting additional scopes via the google_sign_in plugin flutter#50208

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

emerssso · 2020-03-03T23:14:53Z

Note: I haven't gotten to manually test the iOS implementation here yet. Will be able to this evening.

emerssso · 2020-03-05T00:38:20Z

I did find some issues on iOS. Working through them.

emerssso · 2020-03-05T16:52:58Z

iOS. issues addressed. This should be ready for review once changes in #2547 are merged and this gets rebased.

…g of code snippets (#2549) * [e2e] fix flutter driver code snippet in readme and improve formatting

* Move path provider to dir * Fix example * Add dart file * Rename file * Update homepage link

* Exclude path_provider * Add web

…2560) Some platforms might not be able to determine the connectivity status of the device on which the app is running (like some desktop Web browsers). This allows users of the `connectivity` plugin to distinguish between "no connectivity" and "connectivity couldn't be determined". This requires a Major Version bump for users of the plugin who may be switch/case on ConnectivityResult values, since Dart forces users to be exhaustive in those cases (if they don't have a "default" entry, this new value becomes a compilation error in their code). This will also cause a Major Version bump in the core `connectivity` plugin itself. Note that by default, the ConnectivityResults returned by the MethodChannel implementation will now default to 'unknown' if they're not explicitly "none", so this might have some effect in your code!

…nown`." (#2561) The previous push introduced a new major version into the connectivity_platform_interface package. That might not be the best approach. The new version has been unpublished from pub.dev, and this change restores the repo to its previous state. This reverts commit 4411247.

* Add macos exmaple * Update version * Fix analyzer * Fix * space * Remove tests * Address comment * Remove show * Import * Add platform * Use right import

…d Added Tests (#2552) updated _launchUniversalLinkIos to launch the url passed. It could also be done that we remove the url argument passed and open the hardcoded url. Either of the case needs to be done.

Fixes [TAG] Warnings and errors caused as generated on Android Studio build terminal while buidling.

…2564) * Rename StorageDirectory * Update version * Update version to non-breaking * Use 1.0.1

* adding a test for e2e web testing. * chaning the changelog. updating pubspec.yaml version. fixing analyze * merging the changelog * addressing reviewer comments * fix format. addressing reviewer comments * try to run chromedriver on the backend * chrome driver is was running as the main task, preventing test from running . use background_task to run it. use ENV for directory change * change in scripts. remove list from backfround task. change argument of driver * removed background task. it wasn't using the same path * run web tests only on browser * add test on to the web driver test as well. drive-examples are still failing * fix the imports * trying reviever suggestion for drive_example compile errors * test _ imports * Revert "test _ imports" This reverts commit 7cf24d6. * removing the web_test driver file upon reviewers suggestion * format fix

This reverts commit 7d62e8c which landed on the wrong branch.

* Add dart file * Rename file * add interface, rename files, add methods to class * Add to method channel, not done * Add dart file * Rename file * Adds method channel test * Remove prints * Fix imports and version * Format and commentas * Space * Rename apis to path and provide only the string from the platform * Add test and remove null * Format * Add export * Add imports * Completed apis * Fix and works * Improve tests * Remove asyncs * Add imports * Completed apis * Fix and works * Update version * Finish test * Make results per test * Fix * Add dependency * Fix typo nad enum * Change interface version * Address comments * Remove mock call * Typo and import * Remove file

#2567) There's a variety of scenarios where checking at runtime which system features are available is useful. System features are device capabilities that do not change at runtime (for example, FEATURE_BLUETOOTH is always present if the device has a bluetooth radio, even if Bluetooth is presently disabled), so DeviceInfo seems like the right place to put this.

…th just the component name (#2575) * An intent takes an action, component or both, but at least one of them. * Extend the tests and enforce the new assertion on the private constructor as well * Extends unit test to cover no-action, but component name case. * Improves unit test even more by writing literal values in the code

) * Make FlutterRunner launch deterministic when running other tests. * Switch to using FlutterTestRunner

…2482) * Added test for android_alarm_manager background execution Co-authored-by: Collin Jackson <[email protected]>

…2586) * Bumps Flutter & Dart dependencies to stable * Uses spread operator to concisely build arguments * Refactors and cleans up the plugin a bit

…edding. (#2585)

… release (#2590) * Update V2 plugin migration to match current flutter stable * Bump AGP to 3.6.1

…rm_interface. (#2547)

googlebot · 2020-03-11T20:51:21Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

emerssso · 2020-03-11T22:14:48Z

Replaced by #2599

googlebot added the cla: yes label Feb 27, 2020

emerssso changed the title ~~Scope apis mobile~~ [google_sign_in] Add implementations for new Oauth scope methods. Feb 27, 2020

emerssso mentioned this pull request Feb 27, 2020

[google_sign_in] Add new Oauth scope methods to google_sign_in_platform_interface. #2547

Merged

13 tasks

Emmanuel Garcia and others added 24 commits March 11, 2020 13:30

[flutter-plugin-android-lifecycle] Update Gradle version (#2551)

111e637

[e2e] fix flutter driver code snippet in readme and improve formattin…

5ce6e9b

…g of code snippets (#2549) * [e2e] fix flutter driver code snippet in readme and improve formatting

[path_provider] Move package into a path_provider directory (#2542)

2e14771

* Move path provider to dir * Fix example * Add dart file * Rename file * Update homepage link

[path_provider] Create platform interface (#2553)

df0c291

Exclude path_provider packages (#2558)

fcd0f45

* Exclude path_provider * Add web

[path_provider_macos] Adds example app (#2559)

82f9a85

* Add macos exmaple * Update version * Fix analyzer * Fix * space * Remove tests * Address comment * Remove show * Import * Add platform * Use right import

[url_launcher] fix: url_launcher - updated _launchUniversalLinkIos an…

5bc74e4

…d Added Tests (#2552) updated _launchUniversalLinkIos to launch the url passed. It could also be done that we remove the url argument passed and open the hardcoded url. Either of the case needs to be done.

[share] plugin: Update gradle version of example for Android (#2555)

3489dfd

Fixes [TAG] Warnings and errors caused as generated on Android Studio build terminal while buidling.

[path_provider_platform_interface] Rename back to StorageDirectory (#…

e87d73d

…2564) * Rename StorageDirectory * Update version * Update version to non-breaking * Use 1.0.1

Connectivity deprecation fix

122a11e

Revert "Connectivity deprecation fix"

a53b5e1

This reverts commit 7d62e8c which landed on the wrong branch.

[path_provider] Endorse macOS implementation (#2566)

6dfb311

Remove plugin class (#2569)

036a6e1

[webview_flkutter] remove ios workspace setting

15ea190

Remove Swift dependency (#2580)

da00443

Make FlutterRunner launch deterministic when running other tests. (#2584

d0c9985

) * Make FlutterRunner launch deterministic when running other tests. * Switch to using FlutterTestRunner

[android_alarm_manager] Added Espresso test for background execution (#…

6ceda31

…2482) * Added test for android_alarm_manager background execution Co-authored-by: Collin Jackson <[email protected]>

Remove unused variable (#2352)

536add2

ened and others added 13 commits March 11, 2020 13:30

[android_intent] Bump to Flutter stable, remove deprecation warnings (#…

1eba1a2

…2586) * Bumps Flutter & Dart dependencies to stable * Uses spread operator to concisely build arguments * Refactors and cleans up the plugin a bit

[in_app_purchase] Android: fix potential crash when casting in v1 emb…

467c7db

…edding. (#2585)

[connectivity] remove ios workspace setting for example app. (#2592)

7d93486

[device_info] Update Android embedding to match latest Flutter stable…

4dec670

… release (#2590) * Update V2 plugin migration to match current flutter stable * Bump AGP to 3.6.1

[shared_preferences] Fix deprecated API call (#2536)

93f3f6e

[google_sign_in] Add new Oauth scope methods to google_sign_in_platfo…

3bb18ed

…rm_interface. (#2547)

Add scope handling methods to google_sign_in_web.

7cac561

Update version and changelog for web plugin.

567b133

Add scope handling methods to google_sign_in.

822b336

Update version for main plugin.

9a3f790

Fix GoogleSignInPlugin.java formatting.

647699e

Implement requesting multiple scopes on all platforms.

c8306dd

Remove listMissingScopes from implementations.

517c0bd

emerssso requested review from adazh, amirh, bkonyi, collinjackson, cyanglaz, digiter, matthew-carroll and mklim as code owners March 11, 2020 20:50

googlebot added cla: no and removed cla: yes labels Mar 11, 2020

emerssso closed this Mar 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[google_sign_in] Add implementations for new Oauth scope methods. #2562

[google_sign_in] Add implementations for new Oauth scope methods. #2562

emerssso commented Feb 27, 2020

emerssso commented Mar 3, 2020

emerssso commented Mar 5, 2020

emerssso commented Mar 5, 2020

googlebot commented Mar 11, 2020

emerssso commented Mar 11, 2020

[google_sign_in] Add implementations for new Oauth scope methods. #2562

[google_sign_in] Add implementations for new Oauth scope methods. #2562

Conversation

emerssso commented Feb 27, 2020

Description

Related Issues

Checklist

Breaking Change

emerssso commented Mar 3, 2020

emerssso commented Mar 5, 2020

emerssso commented Mar 5, 2020

googlebot commented Mar 11, 2020

emerssso commented Mar 11, 2020