Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher_web] Fix a typo in a test name and fix quote consistency #3010

Merged
merged 2 commits into from
Sep 9, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -145,17 +145,17 @@ void main() {

verify(mockWindow.open('sms:+19725551212?body=hello%20there', ''));
});
test('setting oOnlyLinkTarget as _self opens the url in the same tab',
test('setting webOnlyLinkTarget as _self opens the url in the same tab',
() {
plugin.openNewWindow("https://www.google.com",
webOnlyWindowName: "_self");
plugin.openNewWindow('https://www.google.com',
webOnlyWindowName: '_self');
verify(mockWindow.open('https://www.google.com', '_self'));
});

test('setting webOnlyLinkTarget as _blank opens the url in a new tab',
() {
plugin.openNewWindow("https://www.google.com",
webOnlyWindowName: "_blank");
plugin.openNewWindow('https://www.google.com',
webOnlyWindowName: '_blank');
verify(mockWindow.open('https://www.google.com', '_blank'));
});

Expand Down Expand Up @@ -197,9 +197,9 @@ void main() {
test(
'mailto urls should use _blank if webOnlyWindowName is set as _blank',
() {
plugin.openNewWindow("mailto:[email protected]",
webOnlyWindowName: "_blank");
verify(mockWindow.open("mailto:[email protected]", "_blank"));
plugin.openNewWindow('mailto:[email protected]',
webOnlyWindowName: '_blank');
verify(mockWindow.open('mailto:[email protected]', '_blank'));
});
});
});
Expand Down