Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Support Android 30 #3299

Merged
merged 1 commit into from
Dec 3, 2020
Merged

[camera] Support Android 30 #3299

merged 1 commit into from
Dec 3, 2020

Conversation

blasten
Copy link

@blasten blasten commented Dec 2, 2020 •
edited
Loading

Description

This plugin uses deprecated APIs if targeting Android 30:

Device has been deprecated
    cameraDevice.createCaptureSession(surfaceList, callback, null);
                ^
1 warning

Related Issues

Fixes flutter/flutter#69883

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Dec 2, 2020
@blasten blasten requested a review from mvanbeusekom December 2, 2020 19:59
@blasten
Copy link
Author

blasten commented Dec 2, 2020

@mvanbeusekom In case you haven't seen this issue. Camera needs to be migrated to the new set of APIs to prevent warnings, and add Werror back.

@blasten blasten mentioned this pull request Dec 2, 2020
Closed
13 tasks
@mvanbeusekom
Copy link
Contributor

Thanks for the heads up. I will take a look at it with high priority.

@blasten blasten mentioned this pull request Dec 2, 2020
Closed
13 tasks
@amirh
Copy link
Contributor

amirh commented Dec 2, 2020

Looking just at createCaptureSession, while it was deprecated in API 30 the alternative is only available since API 28, which means we will probably keep the deprecated codepath for awhile.
Would it make sense to silence the warnings in the source files (with targetapi annotation and/or suppresses) instead of ignoring warnings globally for the plugin?

@blasten blasten changed the title [camera] Remove Werror [camera] Support Android 30 Dec 2, 2020
@blasten
Copy link
Author

blasten commented Dec 2, 2020

@amirh PTAL

mvanbeusekom
mvanbeusekom approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom mentioned this pull request Dec 3, 2020
Merged
22 tasks
@blasten blasten merged commit b3e6d1d into flutter:master Dec 3, 2020
@blasten blasten deleted the camera_werror branch December 3, 2020 20:18
amantoux pushed a commit to amantoux/plugins that referenced this pull request Feb 8, 2021
@amantoux
[camera] Support Android 30 (flutter#3299)
a6a9038
adsonpleal pushed a commit to nubank/plugins that referenced this pull request Feb 26, 2021
@adsonpleal
[camera] Support Android 30 (flutter#3299)
9a22bd9
samandmoore added a commit to Betterment/plugins that referenced this pull request Apr 21, 2021
@samandmoore
Merge branch 'upstream-share-final-null-release' into pull-in-upstrea…
85dbace 
…m-changes

* upstream-share-final-null-release: (233 commits)
  [q-w] Update Flutter SDK constraint (flutter#3323)
  [i-p] Update Flutter SDK constraint (flutter#3322)
  [d-g] Update Flutter SDK constraint (flutter#3321)
  [a-c] Update Flutter SDK constraint (flutter#3320)
  [image_picker_platform_interface] Pass Uri to package:http APIs (flutter#3309)
  Exclude null-safe plugins from testing on stable (flutter#3318)
  [documentation] [url_launcher] fix for readme code sample (flutter#3308)
  [camera] Add zoom support to platform interface (flutter#3312)
  update analysis options for nnbd (flutter#3319)
  [camera] Suppress unchecked cast warning in java test (flutter#3316)
  [image_picker] [integration_test] Fixes to make the tree green (flutter#3317)
  [camera] Expanded platform interface to support setting flash mode (flutter#3313)
  [Espresso] Android Code Inspection and Clean up (flutter#3111)
  [camera] Add `camera_platform_interface` package (flutter#3253)
  [camera] Support Android 30 (flutter#3299)
  bump integration test to 1.0.0 (flutter#3295)
  [android_alarm_manager] fix AndroidManifest.xml for android lint issue "XML tag has empty body" (flutter#3288)
  Use testWidgets instead of test to fix failures not surfacing on CI (flutter#3279)
  [file_selector_platform_interface] Migrate to cross_file package (flutter#3286)
  Fix broken link (flutter#3280)
  ...
@andreidiaconu andreidiaconu mentioned this pull request Sep 7, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Camera] Can not use the camera plugin with Android API level 30
3 participants
@blasten @mvanbeusekom @amirh