Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Re-add bin/ to flutter_plugin_tools #3839

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Re-add bin/ to flutter_plugin_tools #3839

merged 1 commit into from
Apr 30, 2021

Conversation

stuartmorgan-g
Copy link
Contributor

This should have been re-added in #3836 but was missed, so it doesn't
work correctly via pub global.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan-g
Re-add bin/ to flutter_plugin_tools
a9b3f6a 
This should have been re-added in flutter#3836 but was missed, so it doesn't
work correctly via `pub global`.
@google-cla google-cla bot added the cla: yes label Apr 30, 2021
@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Apr 30, 2021 •
edited
Loading

Anything else I might have missed in restoring this to working as a stand-alone tool? I'm not sure how to test something comparable to pub global activate/pub global run locally, unfortunately.

@cyanglaz
Copy link
Contributor

@stuartmorgan pub global activate --source path=<path_to_folder>

Now thinking of it, maybe we should ask our ci to do the same (activate the tool from source instead of dart run) so we make sure the activate logic works correctly.

cyanglaz
cyanglaz approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can't think of anything that's missing, a local test will probably be sufficient to figure it out.

@stuartmorgan-g
Copy link
Contributor Author

pub global activate --source path=<path_to_folder>

Ah, perfect! Thanks :)

Looks like this does indeed work now.

@stuartmorgan-g stuartmorgan-g merged commit 54aad07 into flutter:master Apr 30, 2021
@stuartmorgan-g stuartmorgan-g deleted the plugin-tools-activate-fix branch April 30, 2021 19:47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2021
@engine-flutter-autoroll
54aad07 Re-add bin/ to flutter_plugin_tools (flutter/plugins#3839)
5d0e54d
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request May 1, 2021
@engine-flutter-autoroll
54aad07 Re-add bin/ to flutter_plugin_tools (flutter/plugins#3839) (#…
13c346c 
…81567)
samandmoore added a commit to Betterment/plugins that referenced this pull request May 6, 2021
@samandmoore
Merge remote-tracking branch 'upstream/master' into latest-from-upstream
ee602a9 
* upstream/master: (383 commits)
  Add implement and registerWith method to plugins (flutter#3833)
  Update third_party license checking (flutter#3844)
  [tool] add `all` and `dry-run` flags to publish-plugin command (flutter#3776)
  Re-add bin/ to flutter_plugin_tools (flutter#3839)
  switch from using 'tuneup' to analyze to 'dart analyze' (flutter#3837)
  [in_app_purchase] Federated iOS implementation (flutter#3832)
  Prep the tools for publishing (flutter#3836)
  [in_app_purchase] Make PurchaseDetails.status mandatory (flutter#3831)
  Fix grammatical error in contributing guide (flutter#3217)
  [google_sign_in_web] fix README typos.
  [tool] combine run and runAndExitOnError (flutter#3827)
  [camera] android-rework part 2: Android auto focus feature (flutter#3796)
  [in_app_purchase_platform_interface] Added additional fields to ProductDetails (flutter#3826)
  Move all null safety packages' min dart sdk to 2.12.0 (flutter#3822)
  [path_provider_*] code cleanup: sort directives (flutter#3823)
  [in_app_purchase] Implementation of platform interface (flutter#3781)
  [google_sign_in] Add todo WRT correctly setting X-Goog-AuthUser header (flutter#3819)
  [tools] fix version check command not working for new packages (flutter#3818)
  [camera] android-rework part 1: Base classes to support Android Camera features (flutter#3795)
  fix MD (flutter#3815)
  ...
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan-g @fotiDim
Re-add bin/ to flutter_plugin_tools (flutter#3839)
dd5a7cb 
This should have been re-added in flutter#3836 but was missed, so it doesn't
work correctly via `pub global`.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

@blasten blasten Awaiting requested review from blasten

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan-g @cyanglaz