Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Update third_party license checking #3844

Merged
merged 1 commit into from
May 4, 2021
Merged

Update third_party license checking #3844

merged 1 commit into from
May 4, 2021

Conversation

stuartmorgan-g
Copy link
Contributor

In preparation for enabling license checks in flutter/packages, update
the allowed licenses:

  • Allow our license, for cases where we've locally added files
  • Allow the license used by the bsdiff package

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan-g
Update third_party license checking
02481dc 
In preparation for enabling license checks in flutter/packages, update
the allowed licenses:
- Allow our license, for cases where we've locally added files
- Allow the license used by the bsdiff package
@stuartmorgan-g stuartmorgan-g requested a review from cyanglaz May 4, 2021 14:57
@google-cla google-cla bot added the cla: yes label May 4, 2021
cyanglaz
cyanglaz approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g merged commit f13a39e into flutter:master May 4, 2021
@stuartmorgan-g stuartmorgan-g deleted the license-check-packages-third-party branch May 4, 2021 17:53
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 4, 2021
@engine-flutter-autoroll
f13a39e Update third_party license checking (flutter/plugins#3844)
80a6cdd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 4, 2021
@engine-flutter-autoroll
f13a39e Update third_party license checking (flutter/plugins#3844)
af6e4d8
samandmoore added a commit to Betterment/plugins that referenced this pull request May 6, 2021
@samandmoore
Merge remote-tracking branch 'upstream/master' into latest-from-upstream
ee602a9 
* upstream/master: (383 commits)
  Add implement and registerWith method to plugins (flutter#3833)
  Update third_party license checking (flutter#3844)
  [tool] add `all` and `dry-run` flags to publish-plugin command (flutter#3776)
  Re-add bin/ to flutter_plugin_tools (flutter#3839)
  switch from using 'tuneup' to analyze to 'dart analyze' (flutter#3837)
  [in_app_purchase] Federated iOS implementation (flutter#3832)
  Prep the tools for publishing (flutter#3836)
  [in_app_purchase] Make PurchaseDetails.status mandatory (flutter#3831)
  Fix grammatical error in contributing guide (flutter#3217)
  [google_sign_in_web] fix README typos.
  [tool] combine run and runAndExitOnError (flutter#3827)
  [camera] android-rework part 2: Android auto focus feature (flutter#3796)
  [in_app_purchase_platform_interface] Added additional fields to ProductDetails (flutter#3826)
  Move all null safety packages' min dart sdk to 2.12.0 (flutter#3822)
  [path_provider_*] code cleanup: sort directives (flutter#3823)
  [in_app_purchase] Implementation of platform interface (flutter#3781)
  [google_sign_in] Add todo WRT correctly setting X-Goog-AuthUser header (flutter#3819)
  [tools] fix version check command not working for new packages (flutter#3818)
  [camera] android-rework part 1: Base classes to support Android Camera features (flutter#3795)
  fix MD (flutter#3815)
  ...
comlhj1114 pushed a commit to comlhj1114/plugins that referenced this pull request May 6, 2021
@stuartmorgan-g @comlhj1114
Update third_party license checking (flutter#3844)
636a5be 
In preparation for enabling license checks in flutter/packages, update
the allowed licenses:
- Allow our license, for cases where we've locally added files
- Allow the license used by the bsdiff package
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 7, 2021
@engine-flutter-autoroll
f13a39e Update third_party license checking (flutter/plugins#3844)
18ccf0b
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan-g @fotiDim
Update third_party license checking (flutter#3844)
e6e47b9 
In preparation for enabling license checks in flutter/packages, update
the allowed licenses:
- Allow our license, for cases where we've locally added files
- Allow the license used by the bsdiff package
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan-g @cyanglaz