This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[flutter_plugin_tools] Overhaul drive-examples #4099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pported correctly in practice
gaaclarke
approved these changes
Jun 30, 2021
| printError('No Android devices available'); | ||
| throw ToolExit(_exitNoAvailableDevice); | ||
| } | ||
| androidDevice = devices.first; |
There was a problem hiding this comment.
Should we warn if there are more than one device?
There was a problem hiding this comment.
I thought about adding more control over devices via flags, but I figured that absent anyone actually wanting that functionality I'd just do the simplest thing for now, and we can expand later (e.g., adding device choice flags to the command itself) if needed.
| return errors; | ||
| } | ||
|
|
||
| Future<List<String>> _getDevicesForPlatform(String platform) async { |
There was a problem hiding this comment.
nit: Splitting this into parsing the results of devices and calling devices would make it more testable. (Although it looks like you can use MockProcess to test it fine.)
There was a problem hiding this comment.
For now relying on the indirect testing is fine; if we end up needing this in more places and pull this out as a utility method we can split it apart and do direct unit testing.
stuartmorgan-g
added
the
waiting for tree to go green
|
Landing on "red" since |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 1, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Jul 10, 2021
Significantly restructures drive-examples: - Migrates it to the new package-looping base command - Enforces that only one platform is passed, since in practice multiple platforms never actually worked. (The logic is structured so that it will be easy to enable multi-platform if `flutter drive` gains multi-platform support.) - Fixes the issue where `--ios` and `--android` were semi-broken, by doing explicit device targeting for them rather than relying on the default device being the right kind - Extracts much of the logic to helpers so it's easier to understand the flow - Removes support for a legacy integration test file structure that is no longer used - Adds more test coverage; previously no failure cases were actually tested. Fixes flutter/flutter#85147 Part of flutter/flutter#83413
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
Significantly restructures drive-examples: - Migrates it to the new package-looping base command - Enforces that only one platform is passed, since in practice multiple platforms never actually worked. (The logic is structured so that it will be easy to enable multi-platform if `flutter drive` gains multi-platform support.) - Fixes the issue where `--ios` and `--android` were semi-broken, by doing explicit device targeting for them rather than relying on the default device being the right kind - Extracts much of the logic to helpers so it's easier to understand the flow - Removes support for a legacy integration test file structure that is no longer used - Adds more test coverage; previously no failure cases were actually tested. Fixes flutter/flutter#85147 Part of flutter/flutter#83413
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly restructures drive-examples:
flutter drivegains multi-platform support.)--iosand--androidwere semi-broken, by doing explicit device targeting for them rather than relying on the default device being the right kindFixes flutter/flutter#85147
Part of flutter/flutter#83413
Pre-launch Checklist
dart format.)[shared_preferences]///).