Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[flutter_plugin_tools] Overhaul drive-examples #4099

Merged
merged 10 commits into from
Jun 30, 2021
Merged

[flutter_plugin_tools] Overhaul drive-examples #4099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1838700
Enforce that exactly one platform is passed, since multiple aren't su…
stuartmorgan-g Jun 23, 2021
240eeea
Use explicit device target for mobile
stuartmorgan-g Jun 24, 2021
b7e168a
Remove support for the test/ location, which is no longer used
stuartmorgan-g Jun 24, 2021
03f4ed3
Extract some helpers
stuartmorgan-g Jun 24, 2021
9d63a2c
Migrate to new base command
stuartmorgan-g Jun 24, 2021
9d0d125
Add some failure tests
stuartmorgan-g Jun 24, 2021
37662a1
Merge branch 'master' into tool-package-looper-drive-examples
stuartmorgan-g Jun 25, 2021
d3c461d
Merge branch 'master' into tool-package-looper-drive-examples
stuartmorgan-g Jun 30, 2021
e3475b1
Address review comments, fix tests
stuartmorgan-g Jun 30, 2021
49e3647
Merge branch 'master' into tool-package-looper-drive-examples
stuartmorgan-g Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions script/tool/lib/src/build_examples_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import 'dart:async';

import 'package:file/file.dart';
import 'package:path/path.dart' as p;
import 'package:platform/platform.dart';

import 'common/core.dart';
import 'common/package_looping_command.dart';
Expand Down Expand Up @@ -151,8 +150,6 @@ class BuildExamplesCommand extends PackageLoopingCommand {
String flutterBuildType, {
List<String> extraBuildFlags = const <String>[],
}) async {
final String flutterCommand =
const LocalPlatform().isWindows ? 'flutter.bat' : 'flutter';
final String enableExperiment = getStringArg(kEnableExperiment);

final int exitCode = await processRunner.runAndStream(
Expand Down
5 changes: 5 additions & 0 deletions script/tool/lib/src/common/plugin_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import 'package:args/command_runner.dart';
import 'package:file/file.dart';
import 'package:git/git.dart';
import 'package:path/path.dart' as p;
import 'package:platform/platform.dart';

import 'core.dart';
import 'git_version_finder.dart';
Expand Down Expand Up @@ -85,6 +86,10 @@ abstract class PluginCommand extends Command<void> {
int? _shardIndex;
int? _shardCount;

/// The command to use when running `flutter`.
String get flutterCommand =>
const LocalPlatform().isWindows ? 'flutter.bat' : 'flutter';

/// The shard of the overall command execution that this instance should run.
int get shardIndex {
if (_shardIndex == null) {
Expand Down
Loading