[local_auth] Refactor package to make use of new platform interface and native implementations #4701

BeMacized · 2022-01-26T14:06:38Z

This PR is the last in a series to move the local_auth plugin to a federated architecture.

Move local_auth into a subfolder and add a platform interface
([local_auth] Add platform interface to prepare for migration to federated architecture #4697)
Add native implementations for the interface
- Android implementation ([local_auth] Add native Android implementation of platform interface #4700)
- iOS implementation ([local_auth] Add native iOS implementation of platform interface [2] #5207)
Refactor app facing plugin to make use of the platform interface and native implementations.

~~This PR remains in draft mode until the PR for the platform interface package (#4697) as well as the PRs for the native packages (#5207, #4700) have been merged and published.~~

This PR remains in draft mode until #5249 has been merged and published, so that the dependency version may be updated.

Relevant issues:

Pre-launch Checklist

… architecture

…native implementations

…tion_android

…tion_ios

…on_app

… migration

…eration_interface

…tion_interface

…tion_ios

…tion_android

packages/local_auth/local_auth/lib/local_auth.dart

packages/local_auth/local_auth/CHANGELOG.md

packages/local_auth/local_auth/lib/local_auth.dart

packages/local_auth/local_auth/lib/src/local_auth.dart

packages/local_auth/local_auth/pubspec.yaml

stuartmorgan-g

Mostly looks good, but some small notes on the CHANGELOG. (And some minor cleanup to the API docs; I know those are mostly just moved as they were, but since there are some changes to docs related to platforms anyway, this is a good opportunity to do some quick cleanup.)

packages/local_auth/local_auth/CHANGELOG.md

packages/local_auth/local_auth/lib/src/local_auth.dart

packages/local_auth/local_auth/CHANGELOG.md

packages/local_auth/local_auth/lib/src/local_auth.dart

…tion_app

stuartmorgan-g

Looks great! Thanks for all the work on this; I know it ended up being a more complicated federation than some others have been, not least because I missed things during initial review.

…nterface and native implementations (flutter/plugins#4701)

* master: (153 commits) Roll Flutter from fd360c4 to ef5a6da (1 revision) (flutter#5298) [video_player_avfoundation] Applies the standardized transform for videos with different orientations (flutter#5069) Roll Flutter from 3752fb7 to fd360c4 (2 revisions) (flutter#5295) Roll Flutter from 3c4d7a1 to 3752fb7 (11 revisions) (flutter#5294) Add owners for Android implementations (flutter#5293) Roll Flutter from f4875ae to 3c4d7a1 (2 revisions) (flutter#5292) [video_player_web] Stop buffering when browser canPlayThrough. (flutter#5068) Roll Flutter from aa5d7b6 to f4875ae (1 revision) (flutter#5289) Roll Flutter from 44be0b8 to aa5d7b6 (12 revisions) (flutter#5286) Roll Flutter from ec8289c to 44be0b8 (2 revisions) (flutter#5284) Roll Flutter from 329ceae to ec8289c (26 revisions) (flutter#5283) [flutter_plugin_tools] Preserve Dart SDK version in all-plugins-app (flutter#5281) [webview_flutter_wkwebview] Implements the `HostApis` and methods for the `CookieManager`. (flutter#5244) [webview_flutter_wkwebview] Implement `WKNavigationDelegate.didFinishNavigation` as a proof of concept for callback methods (flutter#5199) Roll Flutter from 08e467d to 2b83332 (5 revisions) (flutter#5270) Roll Flutter from e2d1206 to 08e467d (1 revision) (flutter#5268) Roll Flutter from ff9d6e5 to e2d1206 (2 revisions) (flutter#5266) Roll Flutter from 0575932 to ff9d6e5 (1 revision) (flutter#5265) [local_auth] Refactor package to make use of new platform interface and native implementations (flutter#4701) Roll Flutter from cb968c5 to 0575932 (1 revision) (flutter#5263) ...

…nd native implementations (flutter#4701)

BeMacized added 5 commits January 26, 2022 14:39

Add platform interface for local_auth plugin to prepare for federated…

94c4904

… architecture

Add iOS implementation for local_auth_platform_interface

c2b28d2

Add Android implementation for local_auth_platform_interface

7b510a9

Merge branch 'local_auth/federation_ios' into local_auth/federation_app

57c6bfa

Refactor app facing plugin to make use of new platform interface and …

0b425bb

…native implementations

github-actions bot added p: local_auth platform-android platform-ios labels Jan 26, 2022

This was referenced Jan 26, 2022

[local_auth] Add native iOS implementation of platform interface #4699

Closed

[local_auth] Add native Android implementation of platform interface #4700

Merged

[local_auth] Add platform interface to prepare for migration to federated architecture #4697

Merged

BeMacized added 19 commits January 26, 2022 15:11

Fix format

414d74b

Fix analysis issues

c35fd92

Fix format

2c6a9a9

Merge branch 'local_auth/federation_interface' into local_auth/federa…

cebd846

…tion_android

Merge branch 'local_auth/federation_interface' into local_auth/federa…

7f94624

…tion_ios

Merge branch 'local_auth/federation_ios' into local_auth/federation_app

378af3c

Fix analysis warnings

3ebe894

Fix analysis warnings

deea66c

Merge branch 'local_auth/federation_android' into local_auth/federati…

0bbc91b

…on_app

Merge branch 'local_auth/federation_ios' into local_auth/federation_app

7b63b80

Move local_auth plugin into a subfolder in preparation for federation…

bd35a9f

… migration

Process PR Feedback

e10bbb8

Merge branch 'local_auth/federation_initial_move' into local_auth/fed…

86f7ac5

…eration_interface

Merge remote-tracking branch 'upstream/master' into local_auth/federa…

164abaa

…tion_interface

Fix typo in file name

c3d5a1b

Merge remote-tracking branch 'upstream/master' into local_auth/federa…

6f1150e

…tion_ios

Add iOS implementation of platform interface

24556fa

Merge remote-tracking branch 'upstream/master' into local_auth/federa…

f7d2d85

…tion_android

Add Android implementation of platform interface

cdf2cfe

This was referenced Apr 7, 2022

[local_auth] Update app facing package to use default method channel implementation in new platform interface package. #5195

Merged

[local_auth] Add native iOS implementation of platform interface [2] #5207

Merged

Update PR to use newly merged changes from earlier PRs.

3a2db46

github-actions bot removed the platform-android label Apr 12, 2022

BeMacized commented Apr 12, 2022

View reviewed changes

packages/local_auth/local_auth/lib/local_auth.dart Outdated Show resolved Hide resolved

Revert changes to project.pbxproj

267c4a8

github-actions bot removed the platform-ios label Apr 12, 2022

BeMacized marked this pull request as ready for review April 12, 2022 13:01

BeMacized added 2 commits April 12, 2022 15:05

Add missing dev dependency

1a6d9ed

Add missing license header

6188c99

BeMacized requested a review from stuartmorgan-g April 12, 2022 13:15

stuartmorgan-g suggested changes Apr 12, 2022

View reviewed changes

BeMacized mentioned this pull request Apr 13, 2022

[local_auth] Change stopAuthentication to return false instead of throwing on iOS. #5249

Merged

11 tasks

Process PR feedback. Removed deprecated methods.

7103054

BeMacized marked this pull request as draft April 13, 2022 11:49

Update dependency version

1d47b0f

BeMacized marked this pull request as ready for review April 14, 2022 07:03

Fix analysis issue

546fd6d

BeMacized requested a review from stuartmorgan-g April 14, 2022 07:25

stuartmorgan-g suggested changes Apr 14, 2022

View reviewed changes

BeMacized added 2 commits April 14, 2022 16:39

Merge remote-tracking branch 'upstream/master' into local_auth/federa…

c0813d9

…tion_app

Process PR feedback

ae420e6

BeMacized requested a review from stuartmorgan-g April 14, 2022 14:57

stuartmorgan-g approved these changes Apr 14, 2022

View reviewed changes

stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 14, 2022

fluttergithubbot merged commit b2f5465 into flutter:main Apr 14, 2022

engine-flutter-autoroll mentioned this pull request Apr 15, 2022

Roll Plugins from b76f3f51bdc6 to d07eaffb0d76 (7 revisions) flutter/flutter#101987

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 15, 2022

b2f5465c0 [local_auth] Refactor package to make use of new platform i…

3b8a476

…nterface and native implementations (flutter/plugins#4701)

mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023

[local_auth] Refactor package to make use of new platform interface a…

313fd0b

…nd native implementations (flutter#4701)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[local_auth] Refactor package to make use of new platform interface and native implementations #4701

[local_auth] Refactor package to make use of new platform interface and native implementations #4701

Uh oh!

BeMacized commented Jan 26, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

[local_auth] Refactor package to make use of new platform interface and native implementations #4701

[local_auth] Refactor package to make use of new platform interface and native implementations #4701

Uh oh!

Conversation

BeMacized commented Jan 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BeMacized commented Jan 26, 2022 •

edited

Loading