Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[local_auth] Update app facing package to use default method channel implementation in new platform interface package. #5195

Merged

Conversation

BeMacized
Copy link
Contributor

@BeMacized BeMacized commented Apr 7, 2022

This PR updates the app facing package to switch over to the default method channel implementation provided by the new platform interface package.

This is a precursor PR to #4699, #4700 and #4701, and is required to fix the integation tests running properly with those PRs.

Relevant issues:

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.


const MethodChannel _channel = MethodChannel('plugins.flutter.io/local_auth');
export 'package:local_auth_platform_interface/types/biometric_type.dart';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remember to make the version update a breaking change when re-publishing this plugin, since this is where we're introducing the new enum values. (Which doesn't necessarily have to be a breaking change, but I think that's the best way to do it.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a plan, will update this in #4701.

@BeMacized BeMacized marked this pull request as draft April 7, 2022 16:10
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once this is updated to published version of #5196

@BeMacized BeMacized added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 8, 2022
@BeMacized BeMacized marked this pull request as ready for review April 8, 2022 06:52
@BeMacized
Copy link
Contributor Author

@stuartmorgan I'd mark this to be merged, but legacy-version-analyze times out for a reason unknown to me.

@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite legacy-version-analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 8, 2022
@stuartmorgan-g
Copy link
Contributor

@stuartmorgan I'd mark this to be merged, but legacy-version-analyze times out for a reason unknown to me.

For some reason when flutter pub get can't resolve, it manifests on bots as a timeout instead of just failing and logging. So mystery hangs in the build step are usually due to a resolution failure.

In this case, local_auth_platform_interface requires 2.8.0, so this won't resolve on 2.5.0. You just need to bump the app-facing package to 2.8.0 in this PR so that the 2.5 legacy test will be skipped.

@BeMacized BeMacized added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 11, 2022
@fluttergithubbot fluttergithubbot merged commit dd2cd96 into flutter:main Apr 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2022
…d channel implementation in new platform interface package. (flutter/plugins#5195)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2022
…d channel implementation in new platform interface package. (flutter/plugins#5195)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 13, 2022
…d channel implementation in new platform interface package. (flutter/plugins#5195)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 13, 2022
…d channel implementation in new platform interface package. (flutter/plugins#5195)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p: local_auth waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants