-
Notifications
You must be signed in to change notification settings - Fork 7
Review docstrings of argument models #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Note that the actual docstring of a custom Pydantic model should likely never be shown in fractal-web, as described in fractal-analytics-platform/fractal-web#198. Therefore we can keep it in a verbose form, since this is mostly useful as part of the documentation. The attribute descriptions, however, will be shown. |
As part of we also started reviewing attribute descriptions for custom task-arguments Pydantic models (since they will now become part of the JSON Schemas). As soon as it is merged, it would be useful to have a second look at them. |
There are known glitches in how these descriptions are shown in the documentation, but I'm starting to think that we should proceed e.g. with #397 and revamp the whole documentation. |
This is now merged, with the new manifest available at https://fractal-analytics-platform.github.io/fractal-tasks-core/manifest.html. @jluethi would you like to review the new (minimalistic..) attribute docstrings? The relevant classes are the ones listed in
Other than that, this issue can be closed as it only concerns making the documentation prettier. |
And available in 0.10.0a6 |
I'll review those docstrings, thanks @tcompa |
Closed with #440. |
I'll merge #410 without polishing docstrings of the inner models. We should then review their format in view of:
(this also holds for #414, #412, #404, #401)
The text was updated successfully, but these errors were encountered: