Skip to content

Review docstrings of argument models #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tcompa opened this issue Jun 12, 2023 · 7 comments
Closed

Review docstrings of argument models #421

tcompa opened this issue Jun 12, 2023 · 7 comments
Labels
High Priority Current Priorities & Blocking Issues JSON Schemas

Comments

@tcompa
Copy link
Collaborator

tcompa commented Jun 12, 2023

I'll merge #410 without polishing docstrings of the inner models. We should then review their format in view of:

(this also holds for #414, #412, #404, #401)

@tcompa
Copy link
Collaborator Author

tcompa commented Jun 21, 2023

Note that the actual docstring of a custom Pydantic model should likely never be shown in fractal-web, as described in fractal-analytics-platform/fractal-web#198. Therefore we can keep it in a verbose form, since this is mostly useful as part of the documentation.

The attribute descriptions, however, will be shown.

tcompa added a commit that referenced this issue Jun 21, 2023
tcompa added a commit that referenced this issue Jun 22, 2023
@tcompa
Copy link
Collaborator Author

tcompa commented Jun 22, 2023

As part of

we also started reviewing attribute descriptions for custom task-arguments Pydantic models (since they will now become part of the JSON Schemas). As soon as it is merged, it would be useful to have a second look at them.

@tcompa
Copy link
Collaborator Author

tcompa commented Jun 22, 2023

There are known glitches in how these descriptions are shown in the documentation, but I'm starting to think that we should proceed e.g. with #397 and revamp the whole documentation.

@tcompa
Copy link
Collaborator Author

tcompa commented Jun 22, 2023

As part of

we also started reviewing attribute descriptions for custom task-arguments Pydantic models (since they will now become part of the JSON Schemas). As soon as it is merged, it would be useful to have a second look at them.

This is now merged, with the new manifest available at https://fractal-analytics-platform.github.io/fractal-tasks-core/manifest.html.

@jluethi would you like to review the new (minimalistic..) attribute docstrings? The relevant classes are the ones listed in

    "OmeroChannel": "lib_channels.py",
    "Window": "lib_channels.py",
    "Channel": "lib_input_models.py",
    "NapariWorkflowsInput": "lib_input_models.py",
    "NapariWorkflowsOutput": "lib_input_models.py",

Other than that, this issue can be closed as it only concerns making the documentation prettier.

@tcompa
Copy link
Collaborator Author

tcompa commented Jun 22, 2023

This is now merged

And available in 0.10.0a6

@jluethi
Copy link
Collaborator

jluethi commented Jun 23, 2023

I'll review those docstrings, thanks @tcompa

@tcompa
Copy link
Collaborator Author

tcompa commented Jun 23, 2023

Closed with #440.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Current Priorities & Blocking Issues JSON Schemas
Projects
None yet
Development

No branches or pull requests

2 participants