Skip to content

Introduce pydantic model for channels #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jun 12, 2023

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented Jun 8, 2023

No description provided.

@tcompa tcompa linked an issue Jun 8, 2023 that may be closed by this pull request
@tcompa tcompa changed the title WIP Introduce pydantic model for channels Introduce pydantic model for channels Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Coverage report

The coverage rate went from 82.67% to 82.94% ⬆️
The branch rate is 76%.

97.26% of new lines are covered.

Diff Coverage details (click to unfold)

fractal_tasks_core/tasks/create_ome_zarr.py

100% of new lines are covered (82.97% of the complete file).

fractal_tasks_core/tasks/yokogawa_to_ome_zarr.py

100% of new lines are covered (84.68% of the complete file).

fractal_tasks_core/tasks/napari_workflows_wrapper.py

100% of new lines are covered (88.35% of the complete file).

fractal_tasks_core/lib_channels.py

96.49% of new lines are covered (91.56% of the complete file).
Missing lines: 29, 294

fractal_tasks_core/tasks/create_ome_zarr_multiplex.py

100% of new lines are covered (86.97% of the complete file).

fractal_tasks_core/tasks/illumination_correction.py

100% of new lines are covered (77.2% of the complete file).

fractal_tasks_core/tasks/cellpose_segmentation.py

100% of new lines are covered (82% of the complete file).

@tcompa
Copy link
Collaborator Author

tcompa commented Jun 9, 2023

A first version of this PR is ready, but I'll need to review it a bit more carefully.
Also, I'll have to double check it as part of fractal-analytics-platform/fractal-demos#54.

If this all goes smoothly, then a bunch of related issues should be "easy" to address (#414, #412, #404, #401).

@tcompa tcompa marked this pull request as ready for review June 12, 2023 07:16
@tcompa tcompa merged commit 1fc0f69 into main Jun 12, 2023
@tcompa tcompa deleted the 386-introduce-pydantic-model-for-channels branch June 12, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Pydantic model for Channels
1 participant