-
Notifications
You must be signed in to change notification settings - Fork 7
Include Omero-channels-metadata update in import-ome-zarr task #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Omero-channels-metadata update in import-ome-zarr task #579
Conversation
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
…th_id/label` values
Last missing point from #578:
|
This is ready for a review, and it will be the last contribution to the upcoming v0.13.0. |
(see here for a recap: #578 (comment)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Besides the 2 minor remarks on a comment & a message in the NotImplementedError, looks good to merge from my side!
Thanks for the review, merging now |
Checklist before merging
CHANGELOG.md