Skip to content

chore: migrate to react 18 #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

martimalek
Copy link
Contributor

@martimalek martimalek commented Mar 13, 2023

What:

Migrate to react 18


Why:

We want to stop supporting react<18 in Wave 2.0 (#239)

How:

  • Bump react and react-dom versions to ^18.2.0 (not sure if we should target ^18.0.0 instead)
  • Use react's useId instead of the internal generateId in useGeneratedId

Checklist:

  • Fix type errors
  • Use react's useId in Month.tsx instead of the internal generateId
  • Remove our internal util generateId once it's no longer used
  • Remove nanoid dependency
  • Remove IE11 polyfill required for nanoid once it's no longer used (basically remove polyfills.ts)
  • Fix dependency errors (docz is not compatible with React 18)
  • Ready to be merged

Since we already refactored useGeneratedId to not use nanoid I think it makes sense to finish removing nanoid in this PR, that would mean that #240 is a duplicate, I'm keeping it alive for now to hear other's opinions

@martimalek martimalek added this to the Wave@2 milestone Mar 13, 2023
@martimalek martimalek self-assigned this Mar 13, 2023
@martimalek martimalek added the breaking change Breaking changes that require a major version release label Mar 13, 2023
@martimalek
Copy link
Contributor Author

I'm closing this since I was using a fork and now I've opened the PR directly from the branch of this repo in #311

@martimalek martimalek closed this Mar 17, 2023
@martimalek martimalek removed this from the Wave@2 milestone Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking changes that require a major version release
Development

Successfully merging this pull request may close these issues.

1 participant