Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Migrate to react 18
Why:
We want to stop supporting react<18 in Wave 2.0 (#239)
How:
useId
instead of the internalgenerateId
inuseGeneratedId
Checklist:
useId
inMonth.tsx
instead of the internalgenerateId
generateId
once it's no longer usednanoid
dependencynanoid
once it's no longer used (basically removepolyfills.ts
)docz
is not compatible with React 18)Since we already refactored
useGeneratedId
to not usenanoid
I think it makes sense to finish removingnanoid
in this PR, that would mean that #240 is a duplicate, I'm keeping it alive for now to hear other's opinions