Wech 21/support react 18 #311
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martimalek
added
the
breaking change
Docz is not supported anymore. We decided to migrate to a stable solution Co-authored-by: Zack Jones <[email protected]> Co-authored-by: Nikolai Lopin <[email protected]>
Components migrated: * Accordion * Banner * Box * Card
* Checkbox * Datepicker * Dimmer * Divider * Filepicker --------- Co-authored-by: Zack Jones <[email protected]> Co-authored-by: Cristian Sanchez <[email protected]> Co-authored-by: Nikolai Lopin <[email protected]>
* docs: add input story * docs: add label story * docs: add link story * docs: add modal story * docs: add offcanvas story * docs: define argTypes for Input and Label stories * docs(password): add Password to Storybook * docs(phoneinput): add PhoneInput to Storybook * fix(test): update snapshots * docs(pagination): add Pagination to Storybook * docs(radiobutton): add RadioButton to Storybook * docs(popover): add Popover to Storybook --------- Co-authored-by: Aleksandar Spasov <[email protected]> Co-authored-by: Ján Hamara <[email protected]>
Update typescript to the lowest supported version
* Input * Label * Link * Modal * Offcanvas Co-authored-by: Aleksandar Spasov <[email protected]> Co-authored-by: Nikolai Lopin <[email protected]>
* table * tag * text * textarea * toggle * tooltip --------- Co-authored-by: Christian <[email protected]> Co-authored-by: Nikolai Lopin <[email protected]>
* Search * TabBar * Select * SelectList * Skeleton Co-authored-by: Inga Schünemann <[email protected]>
* essentials pages * Logo * Icons * remove IE 11 from the list of supported --------- Co-authored-by: lena <[email protected]> Co-authored-by: Vanessa Knibbe <[email protected]> Co-authored-by: Nikolai Lopin <[email protected]>
martimalek
force-pushed
the
WECH-21/support-react-18
branch
from
d95ae7a to
a045eb8
Compare
added 7 commits
April 21, 2023 13:21
…ECH-21/support-react-18
added 22 commits
April 26, 2023 08:01
ArgsTable is deprecated
2 tasks
* feat(landing): add landing page for Storybook * docs(landing): finish the landing page integration * docs(theme): theme storybook with our branding * refactor(landingpage): mr review modifs part 1 * refactor(landing): wrap landing page mdx in unstyled component --------- Co-authored-by: Ján Hamara <[email protected]>
Fix up default font for theme to Open Sans (my bad, I left behind one commit and merged in the MR before pushing it) Relevant MR: #334
Update 'by Freenow' SVG with one with correct font (my bad, I left behind one commit and merged in the MR before pushing it) Relevant MR: #334
|
I merged the branch to the |
|
@nlopin Why did you decide to do it manually instead of merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Migrate to react 18
Why:
We want to stop supporting react<18 in Wave 2.0 (#239)
How:
useIdinstead of the internalgenerateIdinuseGeneratedIdChecklist:
useIdinMonth.tsxinstead of the internalgenerateIdgenerateIdonce it's no longer usednanoiddependencynanoidonce it's no longer used (basically removepolyfills.ts)doczis not compatible with React 18)Closes #239