Integrate ESLint-deprecated getJSDocComment
#196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettz9
force-pushed
the
getJSDocComment
branch
5 times, most recently
from
f669515 to
1734460
Compare
|
This is pretty much a straight port for this deprecated feature out of ESLint. Can this be merged? If it isn't and eslint removes this code, eslint-plugin-jsdoc will break. |
brettz9
force-pushed
the
getJSDocComment
branch
5 times, most recently
from
8b5f8e1 to
5cc19af
Compare
brettz9
force-pushed
the
getJSDocComment
branch
2 times, most recently
from
ace20c2 to
9f17e76
Compare
gajus
approved these changes
May 16, 2019
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189.
(FWIW, I switched from
getClassJsdocNodetogetClassNodebecause of another PR coming which needed this lower level functionality anyways.)