-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
self-hosted insights/backend/databas page you are looking for was not found #3452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Assigning to @getsentry/support for routing ⏲️ |
Same thing here for 24.11.1, I assume it's releated to change to tabbed UI and some missing feature flag |
Yup, it looks like this MR is not included in 24.11.1 release. |
@a10201 Hello, have you tried adding the feature flag above? ☝ |
flag organizations:insights-domain-view not full work |
@lxShaDoWxl @a10201 a few things to make sure of: You've set Line 5 in f97a5e2
You've set these feature flags on your self-hosted/sentry/sentry.conf.example.py Lines 310 to 326 in f97a5e2
If that's still not the case (meaning you've confirmed that everything is set), please let us know. But if that's the case (meaning you found out that they're not set yet), please re-run the |
Btw this was fixed in 24.12 |
version 24.12.1 sentry.conf.py
.env
|
Weird gonna compare it against my config. @lxShaDoWxl could you verify changes in your cloned repo against 24.12.1 tag itself? |
config files equal qit |
@lxShaDoWxl can you confirm on your |
.env.custom
|
As of 25.1.0 release, I'm still seeing this issue. |
@xpuska513 Can you confirm that you've checked this before? #3452 (comment) |
@aldy505, yes and as per our discussion in Discord looks like the trace viewer is disabled by default. |
Hey @gggritso, can you please pass this on to the Insights frontend team? This "View All" button does not correctly redirects to the |
@aldy505 can-do, thanks 👍🏻 |
closes getsentry/self-hosted#3452 Fixes a self hosted issue where the `view all` on insight overview widgets take you a url without a org and org slug in the path. This is fixed by removing the `bare=true` parameters from the `moduleUrlBuilder`. When `bare= true` we bypass `normalizeUrl` and don't add the customer domain. For example if `bare=true`, `moduleUrlBuilder('db') === /insights/backend/database/`. I think the expectation here was that `LinkButton` would run `normalizeUrl` for us, which might handles adding the org and slug to the path, however, the `normalizeUrl` function works by conditionally replacing `/organizations/slug` with an empty string IF the user is not on a customer domain url. What this means is that anytime `normalizeUrl` is called, we should always include `/organizations/org-slug`. Technically we are running `normalizeUrl` twice with this solution, but there's no serious performance effects of this, and I'd rather run `moduleUrlBuilder` without the `bare` parameter, that way we never have to worry about when we need to use it, and we never run into a similar situation as this.
closes getsentry/self-hosted#3452 Fixes a self hosted issue where the `view all` on insight overview widgets take you a url without a org and org slug in the path. This is fixed by removing the `bare=true` parameters from the `moduleUrlBuilder`. When `bare= true` we bypass `normalizeUrl` and don't add the customer domain. For example if `bare=true`, `moduleUrlBuilder('db') === /insights/backend/database/`. I think the expectation here was that `LinkButton` would run `normalizeUrl` for us, which might handles adding the org and slug to the path, however, the `normalizeUrl` function works by conditionally replacing `/organizations/slug` with an empty string IF the user is not on a customer domain url. What this means is that anytime `normalizeUrl` is called, we should always include `/organizations/org-slug`. Technically we are running `normalizeUrl` twice with this solution, but there's no serious performance effects of this, and I'd rather run `moduleUrlBuilder` without the `bare` parameter, that way we never have to worry about when we need to use it, and we never run into a similar situation as this.
Environment
SaaS (https://sentry.io/)
Steps to Reproduce
The page you are looking for was not found.
You may wish to try the following:
If you entered the address manually, double check the path. Did you forget a trailing slash?
If you followed a link here, try hitting back and reloading the page. It's possible the resource was moved out from under you.
If all else fails, contact us with more details
Not sure what to do? Return to the dashboard
Sentry 24.12.0.dev0
73a925e
Expected Result
not error page
Actual Result
Product Area
Unknown
Link
No response
DSN
No response
Version
No response
The text was updated successfully, but these errors were encountered: