ref(insights): remove insights-domin-view flag from sidebar #81247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81247 +/- ##
==========================================
- Coverage 80.35% 80.32% -0.03%
==========================================
Files 7220 7221 +1
Lines 319582 319350 -232
Branches 20783 20770 -13
==========================================
- Hits 256786 256528 -258
- Misses 62401 62429 +28
+ Partials 395 393 -2 |
gggritso
approved these changes
Nov 25, 2024
DominikB2014
deleted the
DominikB2014/remove-domain-view-flag-sidebar
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
This is part 2 of removing `insights-domain-view` flag (see #81241 for details) In this PR: 1. remove the usage of the flag in the sidebar 2. remove old routes and links to non domain view modules 3. some misc changes related to the the domain view flag being in the sidebar/routes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of removing
insights-domain-viewflag (see #81241 for details)In this PR: