-
-
Notifications
You must be signed in to change notification settings - Fork 255
Fix web deploy GH pages #1406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix web deploy GH pages #1406
Conversation
This is a placeholder for base href that will be replaced by the value of | ||
the `--base-href` argument provided to `flutter build`. | ||
--> | ||
<base href="$FLUTTER_BASE_HREF"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1406 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 181 181
Lines 5792 5792
=======================================
Hits 5227 5227
Misses 565 565 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c70e01a | 331.04 ms | 401.46 ms | 70.42 ms |
abcdba3 | 354.68 ms | 399.04 ms | 44.36 ms |
ef2f368 | 350.06 ms | 429.44 ms | 79.38 ms |
2d3b03d | 309.53 ms | 353.40 ms | 43.87 ms |
ad69abc | 297.35 ms | 385.89 ms | 88.54 ms |
457a85b | 312.37 ms | 376.67 ms | 64.31 ms |
b2cbbc8 | 347.80 ms | 395.31 ms | 47.51 ms |
f2db4ec | 372.46 ms | 469.72 ms | 97.26 ms |
dd1f7d2 | 338.54 ms | 387.10 ms | 48.56 ms |
11fb408 | 320.10 ms | 380.24 ms | 60.14 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c70e01a | 5.94 MiB | 6.97 MiB | 1.03 MiB |
abcdba3 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
ef2f368 | 5.94 MiB | 6.89 MiB | 975.81 KiB |
2d3b03d | 6.06 MiB | 7.09 MiB | 1.03 MiB |
ad69abc | 6.06 MiB | 7.09 MiB | 1.03 MiB |
457a85b | 6.06 MiB | 7.09 MiB | 1.03 MiB |
b2cbbc8 | 6.06 MiB | 7.03 MiB | 995.45 KiB |
f2db4ec | 6.06 MiB | 7.03 MiB | 990.27 KiB |
dd1f7d2 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
11fb408 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3a69405 | 1292.84 ms | 1303.96 ms | 11.12 ms |
b2cbbc8 | 1240.00 ms | 1254.37 ms | 14.37 ms |
0ac1eed | 1278.51 ms | 1285.29 ms | 6.78 ms |
a1a1545 | 1270.85 ms | 1289.82 ms | 18.96 ms |
8e133ad | 1268.19 ms | 1277.37 ms | 9.18 ms |
af2d175 | 1280.37 ms | 1282.24 ms | 1.88 ms |
22ed6cb | 1277.41 ms | 1283.76 ms | 6.35 ms |
ebfead1 | 1271.57 ms | 1284.48 ms | 12.91 ms |
d301b11 | 1260.61 ms | 1272.06 ms | 11.45 ms |
fbf42af | 1253.76 ms | 1269.51 ms | 15.76 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3a69405 | 8.15 MiB | 9.15 MiB | 1018.56 KiB |
b2cbbc8 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
0ac1eed | 8.10 MiB | 9.16 MiB | 1.07 MiB |
a1a1545 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
8e133ad | 8.10 MiB | 9.16 MiB | 1.07 MiB |
af2d175 | 8.15 MiB | 9.12 MiB | 986.22 KiB |
22ed6cb | 8.10 MiB | 9.17 MiB | 1.08 MiB |
ebfead1 | 8.10 MiB | 9.16 MiB | 1.07 MiB |
d301b11 | 8.10 MiB | 9.07 MiB | 1000.82 KiB |
fbf42af | 8.16 MiB | 9.17 MiB | 1.01 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
📜 Description
https://docs.flutter.dev/ui/navigation/url-strategies
#skip-changelog
💡 Motivation and Context
GH web pages is broken for 6 months
https://github.com/getsentry/sentry-dart/actions/runs/4806460022/jobs/8554006880
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps