-
-
Notifications
You must be signed in to change notification settings - Fork 255
ref: Add getCurrentStackTrace #2072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add the wrapper method getCurrentStackTrace, so the SDK crash detection can ignore it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2072 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 54 54
Lines 1789 1789
=======================================
Hits 1705 1705
Misses 84 84 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
117d988 | 376.32 ms | 450.85 ms | 74.53 ms |
2d3b03d | 309.53 ms | 353.40 ms | 43.87 ms |
29297d4 | 377.14 ms | 451.54 ms | 74.40 ms |
9fe67d5 | 373.80 ms | 444.24 ms | 70.45 ms |
f7f46dc | 306.38 ms | 363.32 ms | 56.95 ms |
cd16818 | 316.57 ms | 375.19 ms | 58.62 ms |
6078ddc | 385.72 ms | 463.61 ms | 77.89 ms |
294b7f0 | 367.83 ms | 430.00 ms | 62.17 ms |
1a93825 | 347.31 ms | 424.54 ms | 77.23 ms |
78eeed5 | 298.35 ms | 361.63 ms | 63.28 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
117d988 | 6.33 MiB | 7.26 MiB | 947.03 KiB |
2d3b03d | 6.06 MiB | 7.09 MiB | 1.03 MiB |
29297d4 | 6.34 MiB | 7.28 MiB | 967.79 KiB |
9fe67d5 | 6.33 MiB | 7.29 MiB | 987.27 KiB |
f7f46dc | 6.06 MiB | 7.03 MiB | 993.54 KiB |
cd16818 | 6.26 MiB | 7.20 MiB | 956.08 KiB |
6078ddc | 6.34 MiB | 7.29 MiB | 967.80 KiB |
294b7f0 | 6.33 MiB | 7.26 MiB | 950.21 KiB |
1a93825 | 6.27 MiB | 7.20 MiB | 956.36 KiB |
78eeed5 | 6.16 MiB | 7.14 MiB | 1009.97 KiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7748b7c | 1219.04 ms | 1237.92 ms | 18.88 ms |
f83bc1d | 1247.12 ms | 1249.78 ms | 2.65 ms |
e893df5 | 1247.90 ms | 1262.31 ms | 14.41 ms |
014c3ea | 1298.73 ms | 1351.24 ms | 52.51 ms |
a775d3f | 1241.29 ms | 1241.53 ms | 0.24 ms |
c3e6c82 | 1256.93 ms | 1276.17 ms | 19.24 ms |
5cc82a0 | 1209.24 ms | 1226.31 ms | 17.06 ms |
6d317ea | 1277.27 ms | 1287.47 ms | 10.20 ms |
4b5a4f6 | 1245.28 ms | 1272.27 ms | 26.99 ms |
464b4d0 | 1249.02 ms | 1261.22 ms | 12.20 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7748b7c | 8.28 MiB | 9.34 MiB | 1.06 MiB |
f83bc1d | 8.28 MiB | 9.34 MiB | 1.05 MiB |
e893df5 | 8.09 MiB | 9.07 MiB | 1001.04 KiB |
014c3ea | 8.33 MiB | 9.39 MiB | 1.06 MiB |
a775d3f | 8.28 MiB | 9.34 MiB | 1.06 MiB |
c3e6c82 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
5cc82a0 | 8.33 MiB | 9.40 MiB | 1.07 MiB |
6d317ea | 8.15 MiB | 9.12 MiB | 986.26 KiB |
4b5a4f6 | 8.32 MiB | 9.39 MiB | 1.07 MiB |
464b4d0 | 8.10 MiB | 9.16 MiB | 1.07 MiB |
@buenaflor, how do I fix the failing CI job https://github.com/getsentry/sentry-dart/actions/runs/9264807763/job/25485604253?pr=2072? |
This seems to be an issue with the main branch, I'll fix that in another PR |
Ignore the wrapper function getCurrentStackTrace instead of getSentryException. getCurrentStackTrace is the wrapper function for getting the current stacktrace, and getSentryException uses that function. This was changed with getsentry/sentry-dart#2072 and whipped in sentry-dart 8.2.1.
Ignore the wrapper function getCurrentStackTrace instead of getSentryException. getCurrentStackTrace is the wrapper function for getting the current stacktrace, and getSentryException uses that function. This was changed with getsentry/sentry-dart#2072 and whipped in sentry-dart 8.2.1.
Ignore the wrapper function getCurrentStackTrace instead of getSentryException. getCurrentStackTrace is the wrapper function for getting the current stacktrace, and getSentryException uses that function. This was changed with getsentry/sentry-dart#2072 and shipped in sentry-dart 8.2.1.
Ignore the wrapper function getCurrentStackTrace instead of getSentryException. getCurrentStackTrace is the wrapper function for getting the current stacktrace, and getSentryException uses that function. This was changed with getsentry/sentry-dart#2072 and shipped in sentry-dart 8.2.1.
Ignore the wrapper function getCurrentStackTrace instead of getSentryException. getCurrentStackTrace is the wrapper function for getting the current stacktrace, and getSentryException uses that function. This was changed with getsentry/sentry-dart#2072 and shipped in sentry-dart 8.2.1.
Ignore the wrapper function getCurrentStackTrace instead of getSentryException. getCurrentStackTrace is the wrapper function for getting the current stacktrace, and getSentryException uses that function. This was changed with getsentry/sentry-dart#2072 and shipped in sentry-dart 8.2.1.
📜 Description
Add the wrapper method getCurrentStackTrace so the SDK crash detection can ignore it.
#skip-changelog
💡 Motivation and Context
For getsentry/sentry#71545.
💚 How did you test it?
Unit tests are still green.
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps