Skip to content

fix(sdk-crashes): Ignore Dart SDK function #71545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2024

Conversation

philipphofmann
Copy link
Member

Ignore a specific dart SDK function to ignore false positives.

In an upcoming Dart release, we will wrap the StackTrace.current in SentryExceptionFactory.getSentryException in an extra function so the SDK crash detection can detect crashes in getSentryException.

Ignore a specific dart SDK function to ignore false positives.
@philipphofmann philipphofmann requested review from buenaflor and a team May 28, 2024 06:35
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.90%. Comparing base (ccb3c64) to head (f12eb36).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #71545      +/-   ##
==========================================
- Coverage   77.90%   77.90%   -0.01%     
==========================================
  Files        6549     6549              
  Lines      291279   291279              
  Branches    50400    50400              
==========================================
- Hits       226928   226918      -10     
- Misses      58104    58113       +9     
- Partials     6247     6248       +1     
Files Coverage Δ
...ry/utils/sdk_crashes/sdk_crash_detection_config.py 100.00% <ø> (ø)

... and 9 files with indirect coverage changes

@philipphofmann philipphofmann merged commit ee54e68 into master May 28, 2024
50 checks passed
@philipphofmann philipphofmann deleted the fix/sdk-crashes-dart-sdk-function branch May 28, 2024 07:15
@philipphofmann philipphofmann self-assigned this May 28, 2024
volokluev pushed a commit that referenced this pull request May 28, 2024
Ignore a specific dart SDK function to ignore false positives.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants