Skip to content

Fix: Use App Name if Package Name is not available #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 13, 2021
Merged

Fix: Use App Name if Package Name is not available #411

merged 8 commits into from
Apr 13, 2021

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Apr 12, 2021

📜 Description

Not all platforms have a concept of an package id like on Android or iOS. Thus we need some other identifier. This identifier is the app name.

💡 Motivation and Context

#410

💚 How did you test it?

New test

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Apr 12, 2021

Codecov Report

Merging #411 (7ffd05f) into main (4d42b29) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #411   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files          52       52           
  Lines        1654     1654           
=======================================
  Hits         1501     1501           
  Misses        153      153           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d42b29...7ffd05f. Read the comment docs.

@ueman ueman marked this pull request as ready for review April 13, 2021 06:09
@ueman ueman requested a review from bruno-garcia as a code owner April 13, 2021 06:09
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR alone does not close #410 entirely, but it's good to be merged, LGTM.

@ueman ueman merged commit c1784cd into main Apr 13, 2021
@ueman ueman deleted the fix/appname branch April 13, 2021 07:46
@ueman ueman mentioned this pull request Apr 20, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants