-
-
Notifications
You must be signed in to change notification settings - Fork 255
Fix: Use App Name if Package Name is not available #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #411 +/- ##
=======================================
Coverage 90.74% 90.74%
=======================================
Files 52 52
Lines 1654 1654
=======================================
Hits 1501 1501
Misses 153 153 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR alone does not close #410 entirely, but it's good to be merged, LGTM.
📜 Description
Not all platforms have a concept of an package id like on Android or iOS. Thus we need some other identifier. This identifier is the app name.
💡 Motivation and Context
#410
💚 How did you test it?
New test
📝 Checklist
🔮 Next steps