Report isolate as thread

[ueman]

📜 Description

This PR introduces reporting of the current isolate as thread.

See for example events:

• https://sentry.io/organizations/sentry-sdks/issues/3228921456/events/acd6e57ceafc47c098c79c6997db0f0d/?project=5428562
• https://sentry.io/organizations/sentry-sdks/issues/3229349658/events/863eaa662813446796a5c255a2ef899e/?project=5428562

💡 Motivation and Context

Closes #839

💚 How did you test it?

Added a new test case.

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• I updated the docs if needed
• All tests passing
• No breaking changes

🔮 Next steps

• I'm waiting until Threads are not correctly attached to events #841 is fixed, then I'll look at this again to see if everything works and fix it if needed.
• Create follow up ticket for Report isolate as thread #847 (comment)

[codecov-commenter]

Codecov Report

Merging #847 (32fc922) into main (9bedb1b) will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
+ Coverage   89.76%   89.94%   +0.17%     
==========================================
  Files         102        9      -93     
  Lines        3146      169    -2977     
==========================================
- Hits         2824      152    -2672     
+ Misses        322       17     -305     

Impacted Files	Coverage Δ
dart/lib/src/sentry_client.dart
dart/lib/src/sentry_exception_factory.dart
dart/lib/src/sentry_options.dart
dart/lib/src/protocol/mechanism.dart
dart/lib/src/client_reports/discarded_event.dart
...lib/src/client_reports/client_report_recorder.dart
dart/lib/src/protocol/sentry_thread.dart
dart/lib/src/throwable_mechanism.dart
dart/lib/src/protocol/span_status.dart
dart/lib/src/protocol/debug_image.dart
... and 83 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bedb1b...32fc922. Read the comment docs.

[marandaneto]

Made it a draft since its blocked by #841

[brustolin]

LGTM

[marandaneto]

@ueman please merge main into this branch, so I can test both changes together :) thanks.

[ueman]

@ueman please merge main into this branch, so I can test both changes together :) thanks.

@marandaneto done

[ueman]

@marandaneto When testing with the Flutter example app, you may need to enable the attachThreads option.

[marandaneto]

@ueman not sure if its a bug on the Android SDK or this SDK, but if I capture an exception on the Dart side:

current=false should be true.
I'm using options.attachThreads = true

[ueman]

@ueman not sure if its a bug on the Android SDK or this SDK, but if I capture an exception on the Dart side:

current=false should be true. I'm using options.attachThreads = true

I think this might be an error on the Android side. I even wrote tests, that make sure that current = true.
current is also never set to false as seen here:
https://github.com/ueman/sentry-dart/blob/40072f42a35c41deab011e25a54cbc642774c505/dart/lib/src/sentry_client.dart#L169-L176

and here

https://github.com/ueman/sentry-dart/blob/40072f42a35c41deab011e25a54cbc642774c505/dart/lib/src/sentry_client.dart#L198-L204

[marandaneto]

@ueman I can confirm, since it's correct on iOS.
getsentry/sentry-java#2047

[ueman]

@ueman I can confirm, since it's correct on iOS. getsentry/sentry-java#2047

Soooo, this can be merged then, right?

[ueman]

Since the Sentry Android SDK was updated, this should now also work as expected on Android. The failing CI test is unrelated to my changes, since I didn't touch any iOS code.

[ueman]

I've attached two example events to the PR description. It works really well now.
Also enabled that option for the example app.

For convenience:

• https://sentry.io/organizations/sentry-sdks/issues/3228921456/events/acd6e57ceafc47c098c79c6997db0f0d/?project=5428562
• https://sentry.io/organizations/sentry-sdks/issues/3229349658/events/863eaa662813446796a5c255a2ef899e/?project=5428562

[marandaneto]

I've attached two example events to the PR description. It works really well now. Also enabled that option for the example app.

For convenience:

• sentry.io/organizations/sentry-sdks/issues/3228921456/events/acd6e57ceafc47c098c79c6997db0f0d/?project=5428562
• sentry.io/organizations/sentry-sdks/issues/3229349658/events/863eaa662813446796a5c255a2ef899e/?project=5428562

Thanks @ueman
We are releasing the Android SDK v6 right now and will test it soon.