-
-
Notifications
You must be signed in to change notification settings - Fork 255
Feature: Add threads for Android platform exceptions #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #853 +/- ##
==========================================
+ Coverage 90.30% 90.33% +0.02%
==========================================
Files 119 119
Lines 3764 3785 +21
==========================================
+ Hits 3399 3419 +20
- Misses 365 366 +1
Continue to review full report at Codecov.
|
flutter/lib/src/event_processor/android_platform_exception_event_processor.dart
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the thread naming conventions, @marandaneto probably have better understanding of this.
The rest LGTM.
flutter/lib/src/event_processor/android_platform_exception_event_processor.dart
Outdated
Show resolved
Hide resolved
flutter/lib/src/event_processor/android_platform_exception_event_processor.dart
Outdated
Show resolved
Hide resolved
After thinking a little bit more about it: I think it makes the most sense if the Android thread is marked as |
flutter/lib/src/event_processor/android_platform_exception_event_processor.dart
Show resolved
Hide resolved
Co-authored-by: Manoel Aranda Neto <[email protected]>
📜 Description
Adds thread for android platform exception.
Example event: https://sentry.io/organizations/sentry-sdks/issues/3228921456/events/749fddaffc164a34a6efd82aba0f7f80/?project=5428562
💡 Motivation and Context
Fixes #841
💚 How did you test it?
📝 Checklist
🔮 Next steps