Skip to content

Revert "Breadcrumbs should not be duplicated if there is no mechaism on Android" #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jul 8, 2022

Figure out if tests are broken because of this PR
#938

#skip-changelog

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2022

Codecov Report

Merging #940 (f649ee0) into main (5c37707) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #940      +/-   ##
==========================================
- Coverage   89.94%   89.81%   -0.13%     
==========================================
  Files           9      104      +95     
  Lines         169     3211    +3042     
==========================================
+ Hits          152     2884    +2732     
- Misses         17      327     +310     
Impacted Files Coverage Δ
dart/lib/src/sentry_client.dart 92.53% <100.00%> (ø)
dart/lib/src/diagnostic_logger.dart 16.66% <0.00%> (ø)
dart/lib/src/sentry_sampling_context.dart 100.00% <0.00%> (ø)
dart/lib/src/sentry_measurement.dart 0.00% <0.00%> (ø)
dart/lib/src/protocol/sentry_trace_header.dart 68.75% <0.00%> (ø)
dart/lib/src/noop_hub.dart 20.68% <0.00%> (ø)
dart/lib/src/protocol/sdk_version.dart 100.00% <0.00%> (ø)
dart/lib/src/hub_adapter.dart 10.81% <0.00%> (ø)
...lib/src/client_reports/client_report_recorder.dart 100.00% <0.00%> (ø)
dart/lib/src/protocol/max_request_body_size.dart 100.00% <0.00%> (ø)
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c37707...f649ee0. Read the comment docs.

@marandaneto marandaneto marked this pull request as ready for review July 20, 2022 08:10
@marandaneto marandaneto requested a review from brustolin as a code owner July 20, 2022 08:10
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit 287b3ad into main Jul 20, 2022
@marandaneto marandaneto deleted the revert-936-fix/dup-crumbs-android branch July 20, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants