doc(unleash): Fix wrong config field key #12764
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Curs3W4ll is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
s1gr1d
reviewed
Feb 26, 2025
| @@ -6,7 +6,7 @@ import { UnleashClient } from 'unleash-proxy-client'; | |||
|
|
|||
| Sentry.init({ | |||
| dsn: '___PUBLIC_DSN___', | |||
| integrations: [Sentry.unleashIntegration({unleashClientClass: UnleashClient})], | |||
| integrations: [Sentry.unleashIntegration({featureFlagClientClass: UnleashClient})], | |||
There was a problem hiding this comment.
Thanks for checking this!
This is actually something that could be added to all files in the unleash folder: https://github.com/getsentry/sentry-docs/tree/master/platform-includes/configuration/unleash
There was a problem hiding this comment.
@s1gr1d I've applied it to all the files in the unleash folder
s1gr1d
changed the title
s1gr1d
changed the title
|
Thanks sm for reporting and making the PR @Curs3W4ll ! We will address this asap in #12795 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
While testing the unleash integration, I noticed that the field described in the doc (
unleashClientClass) wasn't present in the integration options type, instead it was namedfeatureFlagClientClass. For me it was with Nuxt.JS.I don't know if it's the same for the other frameworks, if yes, tell me and I will update the other files too!
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES