Skip to content

ref(flags): update unleashIntegration param #12795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2025
Merged

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Feb 20, 2025

Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 10:42pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 10:42pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 10:42pm

@aliu39 aliu39 requested a review from billyvg February 20, 2025 21:29
@aliu39 aliu39 marked this pull request as draft February 20, 2025 21:29
Copy link

codecov bot commented Feb 20, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.94MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/lQkJHyYKW5I_T50T2VqYl/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/lQkJHyYKW5I_T50T2VqYl/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/aGJcAFeR_hmeQSJThi2uk/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/aGJcAFeR_hmeQSJThi2uk/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%

@aliu39
Copy link
Member Author

aliu39 commented Feb 26, 2025

Is there a specific v8 version where it was added? we should use that -- I may even invert this and say something like

AFAIK it's still not released in v8? Yes it'd be good to use.

The unleashClientClass option has been renamed to featureFlagClientClass in v9 of the SDK, please update accordingly.

Sounds good, I can change the alert to this and ship it

@aliu39
Copy link
Member Author

aliu39 commented Feb 26, 2025

Screenshot 2025-02-26 at 2 26 02 PM
Updated to this for all platforms^

@aliu39 aliu39 enabled auto-merge (squash) February 26, 2025 22:30
@aliu39 aliu39 merged commit ab63711 into master Feb 26, 2025
11 checks passed
@aliu39 aliu39 deleted the aliu/unleash-param-update branch February 26, 2025 22:42
codyde added a commit that referenced this pull request Feb 27, 2025
* master: (45 commits)
  feat: Mention that the cookie-sync extension works for previews (#12858)
  ref(flags): update unleashIntegration param (#12795)
  ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK (#12801)
  docs(python): Clarify how to init SDK in `async` app (#12854)
  move content about error capturing to "Capturing Errors and Events" from "Manual Setup" (Next.js) (#12786)
  docs(span-links): Add develop docs for span links (#12829)
  feat(java): add Reactor integration docs (#12686)
  Add Quarkus to community maintained SDKs (#12834)
  Adding unsupported hot reload (#12683)
  Fix broken links (#12844)
  feat(python): Clarification regarding start_transaction (#12835)
  docs(flutter): Fix event serverName reset in samples (#12832)
  ref(insights): move performance docs under insights (#12720)
  Bump API schema to 2e61347a (#12836)
  fix(apple): Usages of sendDefaultPii (#12833)
  Add `sendDefaultPii: true` to React Native init code snippets (#12812)
  Only show Browser vs React Native source maps alert for browser sdks (#12816)
  Add Data Collected page for React Native (#12811)
  Fix React Native Onboarding Option Buttons (#12813)
  Add Hono guide (#12710)
  ...
limbonaut pushed a commit that referenced this pull request Feb 28, 2025
* ref(flags): update unleashIntegration param

* Use info alert

* reword

* Update alert, apply for all platforms, and refactor dup code
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants