-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(js): Add sendDefaultPii: true
to all init calls
#13408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
68f27bd
angular
chargome d74f577
aws-lambda
chargome 04d1feb
browser
chargome e711622
cordova
chargome b6eaf91
gcp
chargome 3d0a818
nest
chargome 705e67c
node
chargome b9a47ac
astro
chargome 4487c22
aws
chargome c946fdf
azure
chargome 40a3eba
bun
chargome b179f14
cap
chargome 882f3ff
cloudflare
chargome 5fa7a19
deno
chargome 8d93f82
electron
chargome d4cc4b7
ember
chargome d092b1c
gatsby
chargome 8c7c163
gcp
chargome fbfe1f5
hono
chargome ec27c60
next
chargome 4964a2c
nuxt
chargome 4efef0c
react
chargome 5c91bb8
remix
chargome 6e47bff
rr
chargome 5baf6ba
solid
chargome f30089e
solidstart
chargome 4f6498f
svelte
chargome a93906c
sveltekit
chargome d7c9f9c
tanstack
chargome 5e12dc6
vue
chargome 37ec0c2
wasm
chargome ba3c8f0
update links
chargome 415ed1d
one more
chargome 5972c9c
Merge branch 'master' into cg-default-pii
chargome File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,14 +91,18 @@ Configuration should happen as early as possible in your application's lifecycle | |
Then forward the `init` method from the sibling Sentry SDK for the framework you use, such as Angular in this example: | ||
|
||
|
||
```typescript {tabTitle: Angular 14+} {filename: app.module.ts} {"onboardingOptions": {"performance": "13-16, 21-30, 50-59", "session-replay": "17-19, 31-37"}} | ||
```typescript {tabTitle: Angular 14+} {filename: app.module.ts} {"onboardingOptions": {"performance": "17-20, 25-34, 54-63", "session-replay": "21-23, 35-42"}} | ||
import * as Sentry from "@sentry/capacitor"; | ||
import * as SentryAngular from "@sentry/angular"; | ||
|
||
Sentry.init( | ||
{ | ||
dsn: "___PUBLIC_DSN___", | ||
|
||
|
||
// Adds request headers and IP for users, for more info visit: | ||
// https://docs.sentry.io/platforms/javascript/guides/capacitor/configuration/options/#sendDefaultPii | ||
sendDefaultPii: true, | ||
|
||
// Set your release version, such as "[email protected]" | ||
release: "my-project-name@<release-name>", | ||
// Set your dist version, such as "1" | ||
|
@@ -155,14 +159,18 @@ Sentry.init( | |
}) | ||
``` | ||
|
||
```typescript {tabTitle: Angular 12, 13} {filename: app.module.ts} {"onboardingOptions": {"performance": "14-17, 22-31, 51-60", "session-replay": "18-20, 32-38"}} | ||
```typescript {tabTitle: Angular 12, 13} {filename: app.module.ts} {"onboardingOptions": {"performance": "18-21, 26-35, 55-64", "session-replay": "22-24, 36-40"}} | ||
// Requires @sentry/capacitor V0. | ||
import * as Sentry from "@sentry/capacitor"; | ||
import * as SentryAngular from "@sentry/angular-ivy"; | ||
|
||
Sentry.init( | ||
{ | ||
dsn: "___PUBLIC_DSN___", | ||
|
||
// Adds request headers and IP for users, for more info visit: | ||
// https://docs.sentry.io/platforms/javascript/guides/capacitor/configuration/options/#sendDefaultPii | ||
sendDefaultPii: true, | ||
|
||
// Set your release version, such as "[email protected]" | ||
release: "my-project-name@<release-name>", | ||
|
@@ -220,13 +228,17 @@ Sentry.init( | |
}) | ||
``` | ||
|
||
```typescript {tabTitle: React} {filename: index.tsx} {"onboardingOptions": {"performance": "13-16, 21-30, 46-55", "session-replay": "17-19, 29-37"}} | ||
```typescript {tabTitle: React} {filename: index.tsx} {"onboardingOptions": {"performance": "17-20, 25-34, 50-59", "session-replay": "21-23, 33-41"}} | ||
import * as Sentry from "@sentry/capacitor"; | ||
import * as SentryReact from "@sentry/react"; | ||
|
||
Sentry.init( | ||
{ | ||
dsn: "___PUBLIC_DSN___", | ||
|
||
// Adds request headers and IP for users, for more info visit: | ||
// https://docs.sentry.io/platforms/javascript/guides/capacitor/configuration/options/#sendDefaultPii | ||
sendDefaultPii: true, | ||
|
||
// Set your release version, such as "[email protected]" | ||
release: "my-project-name@<release-name>", | ||
|
@@ -264,7 +276,7 @@ Sentry.init( | |
); | ||
``` | ||
|
||
```typescript {tabTitle: Vue} {filename: main.ts} {"onboardingOptions": {"performance": "17-20, 25-34, 50-59", "session-replay": "21-23, 33-41"}} | ||
```typescript {tabTitle: Vue} {filename: main.ts} {"onboardingOptions": {"performance": "21-24, 29-38, 54-63", "session-replay": "25-27, 37-45"}} | ||
import * as Sentry from "@sentry/capacitor"; | ||
import * as SentryVue from "@sentry/vue"; | ||
import { createApp } from 'vue' | ||
|
@@ -275,6 +287,10 @@ Sentry.init( | |
{ | ||
app, | ||
dsn: "___PUBLIC_DSN___", | ||
|
||
// Adds request headers and IP for users, for more info visit: | ||
// https://docs.sentry.io/platforms/javascript/guides/capacitor/configuration/options/#sendDefaultPii | ||
sendDefaultPii: true, | ||
|
||
// Set your release version, such as "[email protected]" | ||
release: "my-project-name@<release-name>", | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link 404s
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surprised that CI didn't catch this
edit: nvm it's a comment, of course ci won't