Skip to content

docs(js): Add sendDefaultPii: true to all init calls #13408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Apr 16, 2025

Conversation

chargome
Copy link
Member

No description provided.

@chargome chargome self-assigned this Apr 16, 2025
Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 11:21am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 11:21am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2025 11:21am

Copy link

codecov bot commented Apr 16, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/Og7jpzPB8B2eHgbK0y1JX/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/Og7jpzPB8B2eHgbK0y1JX/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/2VhwsOCH9j1veuRMrpPKE/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/2VhwsOCH9j1veuRMrpPKE/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@stephanie-anderson
Copy link
Contributor

Checks are hanging, will bypass those roles.

Screenshot 2025-04-16 at 21 23 53

@stephanie-anderson stephanie-anderson merged commit 24be747 into master Apr 16, 2025
9 checks passed
@stephanie-anderson stephanie-anderson deleted the cg-default-pii branch April 16, 2025 19:24
@@ -74,7 +74,7 @@ Future<void> main() async {
await SentryFlutter.init(
(options) {
options.dsn = '___PUBLIC_DSN___';
// Adds request headers and IP for users,
// Adds request headers and IP for users, for more info visit:
// visit: https://docs.sentry.io/platforms/dart/guides//data-management/data-collected/ for more info
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link 404s

Copy link
Contributor

@buenaflor buenaflor Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprised that CI didn't catch this

edit: nvm it's a comment, of course ci won't

codyde added a commit that referenced this pull request Apr 19, 2025
* 'master' of https://github.com/getsentry/sentry-docs: (131 commits)
  refactor: migrate Golang and related guides to inline product options syntax (#13413)
  refactor: migrate DotNet sdks to inline product options syntax (#13415)
  add note of the switch sdk (#13431)
  Update spelling in examples.mdx (#13378)
  ref(replay): clarify web & mobile distinction in product docs (#13447)
  fix(java): fix `RestTemplate` auto-instrumentation guide (#13236)
  refactor: migrate Python and related guides to inline product options syntax (#13412)
  Unreal: Document and add `SendDefaultPii = true` to onboarding docs (#13435)
  docs(tracing): Add docs for Previous and Next trace (#13406)
  docs(js): Create Svelte Quick Start guide (#13387)
  Update Profiling SDK version number for iOS/macOS (#13429)
  remove note that workflow notifications alert on new feedback (#13384)
  fix(dart): 404 link (#13430)
  feat(Godot): Update options screenshot on the landing page (#13428)
  add senddefaultpii to powershell (#13426)
  powershell senddefaultpii landing page (#13427)
  chore: update powershell min version requirement (#13425)
  docs(replays): add count_traces to searchable properties (#13422)
  docs(js): Add `sendDefaultPii: true` to all init calls (#13408)
  docs(dotnet): Add `SendDefaultPii = true` option (#13423)
  ...
bitsandfoxes pushed a commit that referenced this pull request Apr 24, 2025
* angular

* aws-lambda

* browser

* cordova

* gcp

* nest

* node

* astro

* aws

* azure

* bun

* cap

* cloudflare

* deno

* electron

* ember

* gatsby

* gcp

* hono

* next

* nuxt

* react

* remix

* rr

* solid

* solidstart

* svelte

* sveltekit

* tanstack

* vue

* wasm

* update links

* one more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants