Skip to content

refactor: migrate Golang and related guides to inline product options syntax #13413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2025

Conversation

a-hariti
Copy link
Collaborator

related to #13361

Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 3:19pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2025 3:19pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2025 3:19pm

Copy link

codecov bot commented Apr 16, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/8vuTi-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/8vuTi-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/2VhwsOCH9j1veuRMrpPKE/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/2VhwsOCH9j1veuRMrpPKE/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Collaborator

@giortzisg giortzisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff. Checked the docs locally and for some reason tabs break after the ___PRODUCT_OPTION_END___:
Screenshot 2025-04-17 at 09 55 19

Also we missed the update on zerolog here.

@a-hariti
Copy link
Collaborator Author

a-hariti commented Apr 17, 2025

  1. can you elaborate on the issue?

  2. good catch @giortzisg!
    but the Zerolog performance range (12-16) doesn't make sense currently, and doesn't have any effect on production as the <OnboardingOptionButtons /> component is lacking the performance option

  3. Fiber doesn't seem to have product options specified, should we add the buttons and performance option range as well?
    Edit: addressed in 373cbde

Copy link
Collaborator

@giortzisg giortzisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job 🚀

@a-hariti
Copy link
Collaborator Author

so to cleanup Zerolog I think we should just remove any options related syntax as we are only offering error monitoring?
(remove the range syntax and the <OnboardingOptionButtons />) @giortzisg

@giortzisg
Copy link
Collaborator

Yeap, that makes sense. Went through other pages that only support error monitoring and they don't have the button, so I guess it also helps with consistency. So let's remove from zerolog and slog. @a-hariti

@giortzisg
Copy link
Collaborator

Also logrus 😅

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Everything works as expected on vercel preview 🏄‍♂️

@a-hariti a-hariti merged commit c6a8d8e into master Apr 18, 2025
15 checks passed
@a-hariti a-hariti deleted the migrate-onboarding-golang branch April 18, 2025 11:24
codyde added a commit that referenced this pull request Apr 19, 2025
* 'master' of https://github.com/getsentry/sentry-docs: (131 commits)
  refactor: migrate Golang and related guides to inline product options syntax (#13413)
  refactor: migrate DotNet sdks to inline product options syntax (#13415)
  add note of the switch sdk (#13431)
  Update spelling in examples.mdx (#13378)
  ref(replay): clarify web & mobile distinction in product docs (#13447)
  fix(java): fix `RestTemplate` auto-instrumentation guide (#13236)
  refactor: migrate Python and related guides to inline product options syntax (#13412)
  Unreal: Document and add `SendDefaultPii = true` to onboarding docs (#13435)
  docs(tracing): Add docs for Previous and Next trace (#13406)
  docs(js): Create Svelte Quick Start guide (#13387)
  Update Profiling SDK version number for iOS/macOS (#13429)
  remove note that workflow notifications alert on new feedback (#13384)
  fix(dart): 404 link (#13430)
  feat(Godot): Update options screenshot on the landing page (#13428)
  add senddefaultpii to powershell (#13426)
  powershell senddefaultpii landing page (#13427)
  chore: update powershell min version requirement (#13425)
  docs(replays): add count_traces to searchable properties (#13422)
  docs(js): Add `sendDefaultPii: true` to all init calls (#13408)
  docs(dotnet): Add `SendDefaultPii = true` option (#13423)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants