-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
refactor: migrate Golang and related guides to inline product options syntax #13413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff. Checked the docs locally and for some reason tabs break after the ___PRODUCT_OPTION_END___
:
Also we missed the update on zerolog here.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome job 🚀
so to cleanup Zerolog I think we should just remove any options related syntax as we are only offering error monitoring? |
Yeap, that makes sense. Went through other pages that only support error monitoring and they don't have the button, so I guess it also helps with consistency. So let's remove from zerolog and slog. @a-hariti |
Also logrus 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Everything works as expected on vercel preview 🏄♂️
* 'master' of https://github.com/getsentry/sentry-docs: (131 commits) refactor: migrate Golang and related guides to inline product options syntax (#13413) refactor: migrate DotNet sdks to inline product options syntax (#13415) add note of the switch sdk (#13431) Update spelling in examples.mdx (#13378) ref(replay): clarify web & mobile distinction in product docs (#13447) fix(java): fix `RestTemplate` auto-instrumentation guide (#13236) refactor: migrate Python and related guides to inline product options syntax (#13412) Unreal: Document and add `SendDefaultPii = true` to onboarding docs (#13435) docs(tracing): Add docs for Previous and Next trace (#13406) docs(js): Create Svelte Quick Start guide (#13387) Update Profiling SDK version number for iOS/macOS (#13429) remove note that workflow notifications alert on new feedback (#13384) fix(dart): 404 link (#13430) feat(Godot): Update options screenshot on the landing page (#13428) add senddefaultpii to powershell (#13426) powershell senddefaultpii landing page (#13427) chore: update powershell min version requirement (#13425) docs(replays): add count_traces to searchable properties (#13422) docs(js): Add `sendDefaultPii: true` to all init calls (#13408) docs(dotnet): Add `SendDefaultPii = true` option (#13423) ...
related to #13361