-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs(js): Create SvelteKit Quick Start guide (Wizard setup) #13480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 246 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
||
1. Open the example page `/sentry-example` in your browser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was changed in the wizard a couple of days ago to align the route with our other meta frameworks (see getsentry/sentry-wizard#973).
1. Open the example page `/sentry-example` in your browser | |
1. Open the example page `/sentry-example-page` in your browser |
|
||
## Verify | ||
Sentry captures both of these errors for you. Additionally, the button click starts a performance trace to measure the time it takes for the API request to complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I'm a bit unhappy with the term "performance trace" because it's not a common term in the observability space. We also moved away from "performance" in the product so I'd rather only call it a "trace" in the quick start docs. Not sure though if this was already discussed and we settled on this compromise, so feel free to disregard :)
Sentry captures both of these errors for you. Additionally, the button click starts a performance trace to measure the time it takes for the API request to complete. | |
Sentry captures both of these errors for you. Additionally, the button click starts a trace to measure the time it takes for the API request to complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for bringing this up!
I removed "performance" here as suggested
…ick-start/sveltekit-wizard
* 'master' of https://github.com/getsentry/sentry-docs: fix(native): add another `crashpad` benefit on macOS to the backend tradeoffs (#13535) chore(develop): Update frontend router testing guidance (#13538) Bump API schema to 1bf27325 (#13537) Fix HTTP headers section in data collected for Java and Android SDK (#13530) Add "Data Collected" page for Unreal Engine SDK (#13532) feat(seer): Update seer docs (#13448) Add an FAQ to trace propagation cheat sheet (#13528) Remove note about 40M SourceMap Limit (#13499) docs(js): Create SvelteKit Quick Start guide (Wizard setup) (#13480) add godot and maui to platforms with screenshot (#13493)
DESCRIBE YOUR PR
Reworked the SvelteKit Getting Started guide into a Quick Start guide (for wizard setup).
closes: #13398
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES