Skip to content

fix(native): add another crashpad benefit on macOS to the backend tradeoffs #13535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

supervacuus
Copy link
Collaborator

fixes getsentry/sentry-native#1213

Also cleaned up the remaining text a bit

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • [ x ] None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@supervacuus supervacuus requested a review from kahest April 28, 2025 18:52
Copy link

vercel bot commented Apr 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2025 7:06pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Apr 28, 2025 7:06pm
develop-docs ⬜️ Ignored (Inspect) Apr 28, 2025 7:06pm

Copy link

codecov bot commented Apr 28, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/bJZem_yBkd0Rqb77-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/bJZem_yBkd0Rqb77-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/gF2TFXh0chq3m67j3dqbG/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/gF2TFXh0chq3m67j3dqbG/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%

Copy link
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@supervacuus supervacuus merged commit 2b3040f into master Apr 29, 2025
15 checks passed
@supervacuus supervacuus deleted the supervacuus-patch-1 branch April 29, 2025 06:46
codyde added a commit that referenced this pull request Apr 29, 2025
* 'master' of https://github.com/getsentry/sentry-docs:
  fix(native): add another `crashpad` benefit on macOS to the backend tradeoffs (#13535)
  chore(develop): Update frontend router testing guidance (#13538)
  Bump API schema to 1bf27325 (#13537)
  Fix HTTP headers section in data collected for Java and Android SDK (#13530)
  Add "Data Collected" page for Unreal Engine SDK (#13532)
  feat(seer): Update seer docs (#13448)
  Add an FAQ to trace propagation cheat sheet (#13528)
  Remove note about 40M SourceMap Limit (#13499)
  docs(js): Create SvelteKit Quick Start guide (Wizard setup) (#13480)
  add godot and maui to platforms with screenshot (#13493)
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Add crashpad vs. breakpad behavior when unhandled signal terminates process
2 participants