Skip to content

feat(apple): Troubleshooting for subclass error #13509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

feat(apple): Troubleshooting for subclass error #13509

merged 1 commit into from
May 2, 2025

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Apr 25, 2025 •
edited
Loading

DESCRIBE YOUR PR

Explain how to resolve a compilation error when subclassing specific classes in the troubleshooting guide.

Fixes getsentry/sentry-cocoa#5079.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@philipphofmann
feat(apple): Troubleshooting for subclass error
1f2621f 
Explain how to resolve a compilation error when subclassing specific
classes in the troubleshooting guide.
@vercel Vercel
Copy link

vercel bot commented Apr 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 7:23am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Apr 25, 2025 7:23am
develop-docs ⬜️ Ignored (Inspect) Apr 25, 2025 7:23am

@philipphofmann philipphofmann mentioned this pull request Apr 25, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/mDmsx2T4IS0sHt8v9tDJ4/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/mDmsx2T4IS0sHt8v9tDJ4/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/qfQkP-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/qfQkP-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️

philprime
philprime approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for documenting this

sfanahata
sfanahata approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview renders, and list looks good.

@philipphofmann philipphofmann merged commit 8490159 into master May 2, 2025
15 checks passed
@philipphofmann philipphofmann deleted the feat/apple-subclass-troubleshooting branch May 2, 2025 08:53
codyde added a commit that referenced this pull request May 5, 2025
@codyde
Merge branch 'master' of https://github.com/getsentry/sentry-docs
fa1b5dc 
* 'master' of https://github.com/getsentry/sentry-docs:
  Fix small typo (#13570)
  Update trace explorer doc for GA (#13560)
  feat(cloudflare): Add jsonc instructions for sourcemaps upload (#13572)
  fix(apple): Missing semicolons in objc config snippets (#13578)
  feat(godot): Enriching events with scene tree data (#13531)
  feat(apple): Troubleshooting for subclass error (#13509)
  Make the API Design doc a bit more consistent (#13511)
  docs(js): Remove outdated/misleading warning (#13484)
  Refine SDK behavior docs for logs to make buffering more clear (#13573)
  fix(spike protection): correct floor calculation explanation (#13556)
  ref(docs): rm session health from early adopter (#13571)
  Bump API schema to 8c0365cd (#13564)
  Updating MCP docs with Video + Claude steps  (#13563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfanahata sfanahata sfanahata approved these changes

@philprime philprime philprime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot subclass User any more
3 participants
@philipphofmann @sfanahata @philprime