Skip to content

feat(cloudflare): Add jsonc instructions for sourcemaps upload #13572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented May 1, 2025

DESCRIBE YOUR PR

ref https://linear.app/getsentry/issue/BUNDLER-51

quick note that aligns with https://developers.cloudflare.com/workers/wrangler/configuration/#source-maps

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@AbhiPrasad AbhiPrasad requested a review from a team May 1, 2025 22:07
@AbhiPrasad AbhiPrasad self-assigned this May 1, 2025
@AbhiPrasad AbhiPrasad requested review from chargome and andreiborza and removed request for a team May 1, 2025 22:07
Copy link

vercel bot commented May 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 3:27pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview May 2, 2025 3:27pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview May 2, 2025 3:27pm

Copy link

codecov bot commented May 1, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.15MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/35Hj-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/35Hj-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/nT4A3Et7VsrNINPApQQv7/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/nT4A3Et7VsrNINPApQQv7/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) May 2, 2025 15:10
@AbhiPrasad AbhiPrasad closed this May 2, 2025
auto-merge was automatically disabled May 2, 2025 15:29

Pull request was closed

@AbhiPrasad AbhiPrasad reopened this May 2, 2025
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) May 2, 2025 15:29
@AbhiPrasad AbhiPrasad merged commit e96dc5b into master May 2, 2025
11 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-jsonc-sourcemaps-cloudflare branch May 2, 2025 15:30
codyde added a commit that referenced this pull request May 5, 2025
* 'master' of https://github.com/getsentry/sentry-docs:
  Fix small typo (#13570)
  Update trace explorer doc for GA (#13560)
  feat(cloudflare): Add jsonc instructions for sourcemaps upload (#13572)
  fix(apple): Missing semicolons in objc config snippets (#13578)
  feat(godot): Enriching events with scene tree data (#13531)
  feat(apple): Troubleshooting for subclass error (#13509)
  Make the API Design doc a bit more consistent (#13511)
  docs(js): Remove outdated/misleading warning (#13484)
  Refine SDK behavior docs for logs to make buffering more clear (#13573)
  fix(spike protection): correct floor calculation explanation (#13556)
  ref(docs): rm session health from early adopter (#13571)
  Bump API schema to 8c0365cd (#13564)
  Updating MCP docs with Video + Claude steps  (#13563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants