Skip to content

Error screen very briefly flashes during loading state of a replay #70077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
billyvg opened this issue May 1, 2024 · 1 comment · Fixed by #72823
Closed

Error screen very briefly flashes during loading state of a replay #70077

billyvg opened this issue May 1, 2024 · 1 comment · Fixed by #72823
Assignees

Comments

@billyvg
Copy link
Member

billyvg commented May 1, 2024

When you visit replay details, you can see that the error screen very briefly flashes during the loading state inside of the replay area.

Screen.Recording.2024-05-01.at.15.25.29.mov
@getsantry
Copy link
Contributor

getsantry bot commented May 1, 2024

Routing to @getsentry/product-owners-replays for triage ⏲️

@billyvg billyvg self-assigned this Jun 14, 2024
billyvg added a commit that referenced this issue Jun 14, 2024
This fixes the error state that quickly flashes when loading a replay.

The `useReplayData` hook makes ~5 requests, but they do not all happen in parallel. The fetching state ends up looking like the following:

* fetch replay, fetch extra errors, fetch platform ("fetching" == true)
* above requests finish ("fetching" == false)
* fetch attachments, fetch extra errors, fetch platform errors ("fetching" == true)

This intermittent fetching state means that we have [components that erroneously render](https://github.com/getsentry/sentry/blob/78334b95bc5ff69816fcaeafff8f67fadf0727c7/static/app/components/replays/replayView.tsx#L43) an error state because it believes API requests have completed and that the data is missing.

Closes #70077
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant