fix(replay): Fix error state quickly flashing when loading replay #72823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the error state that quickly flashes when loading a replay.
The `useReplayData` hook makes ~5 requests, but they do not all happen in parallel. The fetching state ends up looking like the following:
* fetch replay, fetch extra errors, fetch platform ("fetching" == true)
* above requests finish ("fetching" == false)
* fetch attachments, fetch extra errors, fetch platform errors ("fetching" == true)
This intermittent fetching state means that we have [components that erroneously render](https://github.com/getsentry/sentry/blob/78334b95bc5ff69816fcaeafff8f67fadf0727c7/static/app/components/replays/replayView.tsx#L43) an error state because it believes API requests have completed and that the data is missing.
Closes #70077
github-actions
bot
added
the
Scope: Frontend
billyvg
commented
Jun 14, 2024
Comment on lines
+243
to
+244
| hasFetchedAttachments.current = | ||
| hasFetchedAttachments.current || isFetchingAttachments; |
There was a problem hiding this comment.
please double check my logic, but i'm pretty sure this is right and pretty sure we always want to make at least 1 request for attachments or something is wrong.
billyvg
commented
Jun 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72823 +/- ##
==========================================
- Coverage 78.05% 78.04% -0.02%
==========================================
Files 6599 6603 +4
Lines 294323 294363 +40
Branches 50748 50752 +4
==========================================
Hits 229728 229728
+ Misses 58352 58301 -51
- Partials 6243 6334 +91
|
michellewzhang
approved these changes
Jun 17, 2024
aliu39
approved these changes
Jun 17, 2024
Co-authored-by: Michelle Zhang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the error state that quickly flashes when loading a replay.
The
useReplayDatahook makes ~5 requests, but they do not all happen in parallel. The fetching state ends up looking like the following:This intermittent fetching state means that we have components that erroneously render an error state because it believes API requests have completed and that the data is missing.
To test:
Loading a replay should no longer flicker and should no longer flicker with a red error screen. We use
useReplayReaderin quite a few places besides replay details, but I think all of them should benefit from this change.Closes #70077