Skip to content

[User Feedback] Add Option to Hide Feedback Messages on Issue Details & Persist That As a User Setting #74209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jas-kas opened this issue Jul 12, 2024 · 2 comments
Closed

[User Feedback] Add Option to Hide Feedback Messages on Issue Details & Persist That As a User Setting #74209

jas-kas opened this issue Jul 12, 2024 · 2 comments
Assignees
@aliu39
Labels
Sync: Jira Apply to auto-create a Jira shadow ticket

Comments

@jas-kas
Copy link
Member

jas-kas commented Jul 12, 2024 •
edited by sync-by-unito bot
Loading

Problem

TL/DR: Issue Details page can show “User Feedback” section when the feedback comes from a crash report.

Sometimes the feedback is vulgar and Sentry users don’t want to see that.

Solution

Task: Make the feedback collapsable, and remember server-side that feedback is collapsed/hidden. The setting is applied to any feedback rendered directly on the Issue Details page, so if people hide the feedback once there, it’s hidden all the time for all feedbacks on Issue Details. Note: feedbacks on the the /feedback page and the Issue Details > User Feedback tab will still be visible as they are dedicated views for solely feedback messages.

┆Issue is synchronized with this Jira Improvement by Unito
@jas-kas
Copy link
Member Author

jas-kas commented Jul 12, 2024

cc/ @ryan953 @aliu39 @michellewzhang

@michellewzhang
Copy link
Member

michellewzhang commented Jul 12, 2024 •
edited by aliu39
Loading

the process will be similar to what we did for the issue details onboarding banner:

@aliu39 aliu39 mentioned this issue Jul 12, 2024
Merged
aliu39 added a commit that referenced this issue Jul 12, 2024
@aliu39
feat(feedback): add BE prompt for hiding feedback from issue details (#…
9576387 
…74219)

Relates to #74209
This was referenced Jul 12, 2024
Merged
Merged
priscilawebdev pushed a commit that referenced this issue Jul 13, 2024
@aliu39 @priscilawebdev
feat(feedback): add BE prompt for hiding feedback from issue details (#…
3abb0b8 
…74219)

Relates to #74209
aliu39 added a commit that referenced this issue Jul 15, 2024
@aliu39
feat(prompts): support a visible status for un-hiding components (#74228
5a9f327 
)

Needed for #74209. We're using
the prompt backend to persist a user's decision to hide/unhide user
feedback in the issue details page. The goal is to be able to toggle
between
[promptIsDismissed](https://github.com/getsentry/sentry/blob/539945981a00bc93a9525e61e052563df701757a/static/app/utils/promptIsDismissed.tsx#L18)
= true/false.
@irodrigues-git irodrigues-git added the Sync: Jira Apply to auto-create a Jira shadow ticket label Jul 15, 2024
aliu39 added a commit that referenced this issue Jul 16, 2024
@aliu39
feat(feedback): button to hide/show user feedback in issue details (#…
f412d2d 
…74236)

Depends on #74228

Relates to #74209

Adds a button to the "User Feedback" section of issue details page.
Allows members to hide/unhide feedback from **all** issue details in a
project. Persists this decision across reloads using the prompt backend

Updated demo with chevron/drop-down style hiding:


https://github.com/user-attachments/assets/43a02a63-98c0-42bd-8651-f1baeeb22218



Updated loading indicator: (you can see for a split sec at :12)


https://github.com/user-attachments/assets/a2d57c51-e459-467b-9a9c-5e227050d9b7
@aliu39 aliu39 closed this as completed Jul 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aliu39 aliu39

Labels
Sync: Jira Apply to auto-create a Jira shadow ticket
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@michellewzhang @jas-kas @irodrigues-git @aliu39